From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hiroyuki Mikita <h.mikita89@gmail.com>
Subject: Re: [PATCH] timer: remove unnecessary timer add call
Date: Tue, 26 Jul 2016 00:15:29 +0900
Message-ID: <CAO_n4D1vrhgc0oaR-bhczM3k+f7BhvbsvhGU8bU_cq5TM188gA@mail.gmail.com>
References: <1468776950-32693-1-git-send-email-h.mikita89@gmail.com>
 <D3B810DC.14468%rsanford@akamai.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Sanford, Robert" <rsanford@akamai.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com
 [209.85.220.193]) by dpdk.org (Postfix) with ESMTP id 479575597
 for <dev@dpdk.org>; Mon, 25 Jul 2016 17:15:49 +0200 (CEST)
Received: by mail-qk0-f193.google.com with SMTP id q62so14536616qkf.2
 for <dev@dpdk.org>; Mon, 25 Jul 2016 08:15:49 -0700 (PDT)
In-Reply-To: <D3B810DC.14468%rsanford@akamai.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Fixes: a4b7a5a45cf5 ("timer: fix race condition")

2016-07-23 7:06 GMT+09:00 Sanford, Robert <rsanford@akamai.com>:
>
>
> On 7/17/16 1:35 PM, "Hiroyuki Mikita" <h.mikita89@gmail.com> wrote:
>
>>When timer_set_running_state() fails in rte_timer_manage(),
>>the failed timer is put back on pending-list.
>>In this case, another core tries to reset or stop the timer.
>>It does not need to be on pending-list
>>
>>Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
>>---
>> lib/librte_timer/rte_timer.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>>diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
>>index 3dcdab5..94878d3 100644
>>--- a/lib/librte_timer/rte_timer.c
>>+++ b/lib/librte_timer/rte_timer.c
>>@@ -562,10 +562,9 @@ void rte_timer_manage(void)
>>                       pprev = &tim->sl_next[0];
>>               } else {
>>                       /* another core is trying to re-config this one,
>>-                       * remove it from local expired list and put it
>>-                       * back on the priv_timer[] skip list */
>>+                       * remove it from local expired list
>>+                       */
>>                       *pprev = next_tim;
>>-                      timer_add(tim, lcore_id, 1);
>>               }
>>       }
>>
>>--
>>2.7.4
>>
>
> Acked-by: Robert Sanford <rsanford@akamai.com>
>