From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 1/2] enic: silence log message
Date: Wed, 20 May 2015 10:47:01 -0700
Message-ID: <CAOaVG141jCEhMn=kYfjTSXscijWHw6gJsraxpmSp2dno-td+Qw@mail.gmail.com>
References: <1428514670-7982-1-git-send-email-stephen@networkplumber.org>
 <1428514670-7982-2-git-send-email-stephen@networkplumber.org>
 <20150519100853.GB11036@bricha3-MOBL3>
 <D182B40C.398B1%ssujith@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@brocade.com>
To: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ig0-f174.google.com (mail-ig0-f174.google.com
 [209.85.213.174]) by dpdk.org (Postfix) with ESMTP id 74BA6C320
 for <dev@dpdk.org>; Wed, 20 May 2015 19:47:02 +0200 (CEST)
Received: by igbyr2 with SMTP id yr2so108945037igb.0
 for <dev@dpdk.org>; Wed, 20 May 2015 10:47:01 -0700 (PDT)
In-Reply-To: <D182B40C.398B1%ssujith@cisco.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Other drivers are quiet, why does this one need to be noisy

On Wed, May 20, 2015 at 9:30 AM, Sujith Sankar (ssujith) <ssujith@cisco.com>
wrote:

>
>
> On 19/05/15 3:38 pm, "Bruce Richardson" <bruce.richardson@intel.com>
> wrote:
>
> >On Wed, Apr 08, 2015 at 10:37:49AM -0700, Stephen Hemminger wrote:
> >> From: Stephen Hemminger <shemming@brocade.com>
> >>
> >> Silence is normal. drivers should speak only when spoken to and not
> >> be chatty.
> >>
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> >Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> >> ---
> >>  lib/librte_pmd_enic/enic_main.c | 2 --
> >>  1 file changed, 2 deletions(-)
> >>
> >> diff --git a/lib/librte_pmd_enic/enic_main.c
> >>b/lib/librte_pmd_enic/enic_main.c
> >> index 0892b3e..508621e 100644
> >> --- a/lib/librte_pmd_enic/enic_main.c
> >> +++ b/lib/librte_pmd_enic/enic_main.c
> >> @@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic)
> >>      struct rte_pci_device *pdev = enic->pdev;
> >>      int err = -1;
> >>
> >> -    dev_debug(enic, " Initializing ENIC PMD version %s\n",
> DRV_VERSION);
> >> -
>
> It would be good to retain this under RTE_LIBRTE_ENIC_DEBUG.
>
> >>      enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
> >>      enic->bar0.len = pdev->mem_resource[0].len;
> >>
> >> --
> >> 2.1.4
> >>
>
>