From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Boule Subject: Re: ixgbe : query regarding your code changes for VF mac add Date: Wed, 20 Apr 2016 09:31:30 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: santosh Return-path: Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com [209.85.217.172]) by dpdk.org (Postfix) with ESMTP id 4752E2C17 for ; Wed, 20 Apr 2016 09:31:31 +0200 (CEST) Received: by mail-lb0-f172.google.com with SMTP id ys16so4457671lbb.3 for ; Wed, 20 Apr 2016 00:31:31 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Santosh, I do not get exactly what you attempt to do on a VF. Are you first deleting the so-called permanent MAC address by a call to the function ixgbevf_remove_mac_addr() ? This operation is not allowed. Can you explain exactly the sequence of operations that are done, so that I can understand how the test (memcmp(hw->mac.perm_addr, mac_addr, sizeof(struct ether_addr)) =3D=3D 0) in the function ixgbevf_add_mac_addr() prevents them to be successfully performed. Ivan PS : please, can you CC your emails to dev@dpdk.org 2016-04-19 17:01 GMT+02:00 santosh : > Hi Ivan, > > Your following code changes causing issue in Vmware environment. > > ----------------------------------- ------------------- > ------------------------------ > + /* > + * On a 82599 VF, adding again the same MAC addr is not an idempotent > + * operation. Trap this case to avoid exhausting the [very limited] > + * set of PF resources used to store VF MAC addresses. > + */ > + if (memcmp(hw->mac.perm_addr, mac_addr, sizeof(struct ether_addr)) =3D= =3D 0) > + return; > diag =3D ixgbevf_set_uc_addr_vf(hw, 2, mac_addr->addr_bytes); > -------------------------------------------------------------------- > ------------- ------- > > > Issue: > At CLI , we have provision to add /del MAC of an interface. > During MAC delete, existing MAC is deleted and default MAC is applied. > This default MAC is not being applied in VMware environment > successfully due to "return" statement > in your above code changes. As a result traffic is stopped completely. > If I remove above > "return" statement then traffic continues to flow after MAC delete. > > Please let me know your suggestion to handle this scenario . If I > remove "return" what will be the consequences ? > > If removing "return" statement is not good idea then what are other > way to handle MAC delete scenario ? we have only 1 VF per PF in our > setup as of now. > > > Thanks > Santosh > --=20 Ivan BOULE 6WIND Software Engineer Tel: +33 1 39 30 92 47 Mob: + 33 6 77 25 26 38 Fax: +33 1 39 30 92 11 ivan.boule@6wind.com www.6wind.com Join the Multicore Packet Processing Forum: www.multicorepacketprocessing.com Ce courriel ainsi que toutes les pi=C3=A8ces jointes, est uniquement destin= =C3=A9 =C3=A0 son ou ses destinataires. Il contient des informations confidentielles qui sont la propri=C3=A9t=C3=A9 de 6WIND. Toute r=C3=A9v=C3=A9lation, distribut= ion ou copie des informations qu'il contient est strictement interdite. Si vous avez re=C3= =A7u ce message par erreur, veuillez imm=C3=A9diatement le signaler =C3=A0 l'=C3=A9= metteur et d=C3=A9truire toutes les donn=C3=A9es re=C3=A7ues. This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to 6WIND. All unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.