From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jianbo Liu <jianbo.liu@linaro.org>
Subject: Re: [PATCH v3 4/4] eal/arm: introduce
	CONFIG_RTE_ARCH_ARM_NEON_MEMCPY
Date: Mon, 21 Mar 2016 13:42:31 +0800
Message-ID: <CAP4Qi38HUkbgkPNnYAxR95Cmzu-B+gKFdz8Xj4fRBaunijsqyA@mail.gmail.com>
References: <1458379590-18618-1-git-send-email-viktorin@rehivetech.com>
 <1458417485-29436-1-git-send-email-viktorin@rehivetech.com>
 <1458417485-29436-5-git-send-email-viktorin@rehivetech.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>, tomaszx.kulasek@intel.com
To: Jan Viktorin <viktorin@rehivetech.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-yw0-f173.google.com (mail-yw0-f173.google.com
 [209.85.161.173]) by dpdk.org (Postfix) with ESMTP id 91F9F2C48
 for <dev@dpdk.org>; Mon, 21 Mar 2016 06:42:31 +0100 (CET)
Received: by mail-yw0-f173.google.com with SMTP id g3so204127250ywa.3
 for <dev@dpdk.org>; Sun, 20 Mar 2016 22:42:31 -0700 (PDT)
In-Reply-To: <1458417485-29436-5-git-send-email-viktorin@rehivetech.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 20 March 2016 at 03:58, Jan Viktorin <viktorin@rehivetech.com> wrote:
> The flag is used to enable memcpy optimizations in EAL. As it is not always
> the performance benefit, the flag allows to disable it.
>
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> ---
>  config/defconfig_arm-armv7a-linuxapp-gcc               | 1 +
>  lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h | 8 ++++++--
>  2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc
> index 96c3343..2c60c2c 100644
> --- a/config/defconfig_arm-armv7a-linuxapp-gcc
> +++ b/config/defconfig_arm-armv7a-linuxapp-gcc
> @@ -36,6 +36,7 @@ CONFIG_RTE_ARCH="arm"
>  CONFIG_RTE_ARCH_ARM=y
>  CONFIG_RTE_ARCH_ARMv7=y
>  CONFIG_RTE_ARCH_ARM_TUNE="cortex-a9"
> +CONFIG_RTE_ARCH_ARM_NEON_MEMCPY=y
>
If it's not always benefit, why not disable here since it is common
armv7a config, and enable in your or other user's own config file?

Thanks!
Jianbo