From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jianbo Liu <jianbo.liu@linaro.org>
Subject: Re: [PATCH v2] sched: add neon optimizations
Date: Fri, 28 Apr 2017 16:50:38 +0800
Message-ID: <CAP4Qi3_5zZo=D7UAc6LS5BoEwOL_uCWE15G_bSsBaS7mkyVymQ@mail.gmail.com>
References: <20170427130007.33210-1-ashwin.sekhar@caviumnetworks.com>
 <20170428061548.44424-1-ashwin.sekhar@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: thomas@monjalon.net, cristian.dumitrescu@intel.com,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
To: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-yw0-f177.google.com (mail-yw0-f177.google.com
 [209.85.161.177]) by dpdk.org (Postfix) with ESMTP id AAEDA559C
 for <dev@dpdk.org>; Fri, 28 Apr 2017 10:50:39 +0200 (CEST)
Received: by mail-yw0-f177.google.com with SMTP id l18so27678036ywh.3
 for <dev@dpdk.org>; Fri, 28 Apr 2017 01:50:39 -0700 (PDT)
In-Reply-To: <20170428061548.44424-1-ashwin.sekhar@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 28 April 2017 at 14:15, Ashwin Sekhar T K
<ashwin.sekhar@caviumnetworks.com> wrote:
> * Removed setting CONFIG_RTE_SCHED_VECTOR=n from armv8a config
>   so that the setting from common_base is taken as the default
>   setting for armv8a
> * Verified the changes with sched_autotest unit test case
>
> Signed-off-by: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>
> ---
> v2:
> * Removed line CONFIG_RTE_SCHED_VECTOR=n from config/defconfig_arm64-armv8a-linuxapp-gcc
> * Modified the commit message and body to reflect the changes
>
>  config/defconfig_arm64-armv8a-linuxapp-gcc |  2 --
>  lib/librte_sched/rte_sched.c               | 22 ++++++++++++++++++++++
>  2 files changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
> index 65888ce..6415f46 100644
> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> @@ -47,5 +47,3 @@ CONFIG_RTE_EAL_IGB_UIO=n
>  CONFIG_RTE_LIBRTE_FM10K_PMD=n
>  CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
>  CONFIG_RTE_LIBRTE_AVP_PMD=n
> -
> -CONFIG_RTE_SCHED_VECTOR=n
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index 614705d..4ba476a 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -58,6 +58,8 @@
>
>  #if defined(__SSE4__)
>  #define SCHED_VECTOR_SSE4
> +#elif defined(RTE_MACHINE_CPUFLAG_NEON)
> +#define SCHED_VECTOR_NEON
>  #endif
>
>  #endif
> @@ -1732,6 +1734,26 @@ grinder_pipe_exists(struct rte_sched_port *port, uint32_t base_pipe)
>         return 1;
>  }
>
> +#elif defined(SCHED_VECTOR_NEON)
> +
> +static inline int
> +grinder_pipe_exists(struct rte_sched_port *port, uint32_t base_pipe)
> +{
> +       uint32x4_t index, pipes;
> +       uint32_t *pos = (uint32_t *)port->grinder_base_bmp_pos;
> +
> +       index = vmovq_n_u32(base_pipe);
> +       pipes = vld1q_u32(pos);
> +       if (!vminvq_u32(veorq_u32(pipes, index)))
> +               return 1;
> +
> +       pipes = vld1q_u32(pos + 4);
> +       if (!vminvq_u32(veorq_u32(pipes, index)))
> +               return 1;
> +
> +       return 0;
> +}
> +
>  #else
>
>  static inline int
> --
> 2.7.4
>

Acked-by: Jianbo Liu <jianbo.liu@linaro.org>