From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcin Wojtas <mw@semihalf.com>
Subject: Re: [PATCH 1/1] ena: fix SIGFPE with 0 rx queues
Date: Thu, 21 Jun 2018 12:14:48 +0200
Message-ID: <CAPv3WKdNHjrLTStcx5NseW7YLq2Z3SKQNCHr49BSbT17yS5TVA@mail.gmail.com>
References: <20180620163217.3770-1-daria.kolistratova@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: "Tzalik, Guy" <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>,
 dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 =?UTF-8?Q?Micha=C5=82_Krawczyk?= <mk@semihalf.com>
To: Daria Kolistratova <daria.kolistratova@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-it0-f66.google.com (mail-it0-f66.google.com
 [209.85.214.66]) by dpdk.org (Postfix) with ESMTP id 207531BB20
 for <dev@dpdk.org>; Thu, 21 Jun 2018 12:14:50 +0200 (CEST)
Received: by mail-it0-f66.google.com with SMTP id j135-v6so3995344itj.1
 for <dev@dpdk.org>; Thu, 21 Jun 2018 03:14:50 -0700 (PDT)
In-Reply-To: <20180620163217.3770-1-daria.kolistratova@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

+ Ferruh and Michal

2018-06-20 18:32 GMT+02:00 Daria Kolistratova <daria.kolistratova@intel.com>:
> When  he number of rx queues is 0
> (what can be when application does not receive)
> failed with SIGFPE.
> Fixed adding zero check before division.
>
> Signed-off-by: Daria Kolistratova <daria.kolistratova@intel.com>
> ---
>  drivers/net/ena/ena_ethdev.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index 9ae73e331..76c483921 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -684,7 +684,11 @@ static int ena_rss_init_default(struct ena_adapter *adapter)
>         }
>
>         for (i = 0; i < ENA_RX_RSS_TABLE_SIZE; i++) {
> -               val = i % nb_rx_queues;
> +               if (nb_rx_queues != 0)
> +                       val = i % nb_rx_queues;
> +               else
> +                       val = 0;
> +
>                 rc = ena_com_indirect_table_fill_entry(ena_dev, i,
>                                                        ENA_IO_RXQ_IDX(val));
>                 if (unlikely(rc && (rc != ENA_COM_UNSUPPORTED))) {
> --
> 2.14.4
>