From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin Wojtas Subject: Re: [PATCH v2 10/12] net/mvpp2: align documentation with MUSDK 18.09 Date: Mon, 24 Sep 2018 13:51:56 +0200 Message-ID: References: <1536045016-32008-1-git-send-email-tdu@semihalf.com> <1536068953-9352-11-git-send-email-tdu@semihalf.com> <10679582.IxOl8a41ax@xps> <03d2129a-2ceb-a483-cc22-ed354751a13f@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: thomas@monjalon.net, =?UTF-8?Q?Tomasz_Duszy=C5=84ski?= , Natalie Samsonov , dev@dpdk.org, Andrzej Ostruszka To: Ferruh Yigit Return-path: Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 799F41AFF for ; Mon, 24 Sep 2018 13:52:15 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id q4-v6so17333561iob.8 for ; Mon, 24 Sep 2018 04:52:15 -0700 (PDT) In-Reply-To: <03d2129a-2ceb-a483-cc22-ed354751a13f@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, pon., 24 wrz 2018 o 13:38 Ferruh Yigit napisa=C5= =82(a): > > On 9/23/2018 11:40 PM, Thomas Monjalon wrote: > > 19/09/2018 19:15, Ferruh Yigit: > >> On 9/4/2018 2:49 PM, Tomasz Duszynski wrote: > >>> From: Natalie Samsonov > >>> --- a/doc/guides/nics/mvpp2.rst > >>> +++ b/doc/guides/nics/mvpp2.rst > >>> - git clone https://github.com/MarvellEmbeddedProcessors/linux-ma= rvell.git -b linux-4.4.52-armada-17.10 > >>> + git clone https://github.com/MarvellEmbeddedProcessors/linux-ma= rvell.git -b linux-4.4.120-armada-18.09 > >> > >> There is a strict dependency to MUSDK 18.09, dpdk18.11 won't compile w= ith older > >> versions. It is hard to trace this dependency, what do you think havin= g a matrix > >> in DPDK documentation showing which DPDK version supports which MUSDK? > > > > It does not compile even with MUSDK 18.09. > > > > With MUSDK 18.09, the error is: > > drivers/crypto/mvsam/rte_mrvl_pmd.c:867:26: error: 'SAM_HW_RING_N= UM' undeclared > > I confirm same error. I wasn't building with crypto PMD enabled so not ca= ught it. > > > > > The explanation is in MUSDK: > > commit 9bf8b3ca4ddfa00619c0023dfb08ae1601054fce > > Author: Dmitri Epshtein > > Date: Mon Nov 20 10:38:31 2017 +0200 > > > > sam: remove SAM_HW_RING_NUM from APIs > > > > Use function: > > u32 sam_get_num_cios(u32 inst); > > > > As a consequence, next-net cannot be pulled! > > Got it, should I drop the patchset from tree? We're checking the error and will provide fix asap. Please let know if this should be another version of the entire patchset or fix on top. Sorry for the problems. Best regards, Marcin