From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Stokes, Ian" <ian.stokes@intel.com>
Subject: Re: [RFC] ethdev: add min/max MTU to device info
Date: Thu, 22 Nov 2018 09:58:30 +0000
Message-ID: <CD7C01071941AC429549C17338DB8A52894E4693@IRSMSX101.ger.corp.intel.com>
References: <20180905164157.844-1-stephen@networkplumber.org>
 <b817acca-439d-da4f-311d-13b5a25cb417@solarflare.com>
 <20180906115252.79226596@shemminger-XPS-13-9360>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>, Andrew Rybchenko
 <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 1A0AA1B217
 for <dev@dpdk.org>; Thu, 22 Nov 2018 10:58:33 +0100 (CET)
In-Reply-To: <20180906115252.79226596@shemminger-XPS-13-9360>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> On Thu, 6 Sep 2018 09:29:32 +0300
> Andrew Rybchenko <arybchenko@solarflare.com> wrote:
>=20
> > On 09/05/2018 07:41 PM, Stephen Hemminger wrote:
> > > This addresses the usability issue raised by OVS at DPDK Userspace
> > > summit. It adds general min/max mtu into device info. For
> > > compatiablity, and to save space, it fits in a hole in existing
> structure.
> >
> > It is true for amd64, but it looks like it is false on 32-bit. So, ABI
> > breakage.
>=20
> Yes it is ABI change on 32 bit, but 18.11 is a major release where this i=
s
> allowed/expected.

Thanks for this work Stephen, I've tested it with OVS DPDK and it resolves =
the issues as described, if it's to be part of DPDK 19.02 I guess there sho=
uld be an ABI breakage notification in 18.11?