From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: [PATCH] validate_abi: build faster by augmenting
 make with job count
Date: Wed, 20 Jul 2016 19:47:32 +0000
Message-ID: <CDB4778C-5EF7-4728-A77D-229F76A13225@intel.com>
References: <1469034588-1847-1-git-send-email-nhorman@tuxdriver.com>
 <6330653.K6A9CLrOZy@xps13>
 <20160720174849.GE28844@hmsreliant.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, Neil Horman
 <nhorman@tuxdriver.com>, "dev@dpdk.org" <dev@dpdk.org>, "Mcnamara, John"
 <john.mcnamara@intel.com>
To: Neil Horman <nhorman@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 063523777
 for <dev@dpdk.org>; Wed, 20 Jul 2016 21:47:34 +0200 (CEST)
In-Reply-To: <20160720174849.GE28844@hmsreliant.think-freely.org>
Content-Language: en-US
Content-ID: <7F152377F59E3948883CE37B7301F505@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> On Jul 20, 2016, at 12:48 PM, Neil Horman <nhorman@redhat.com> wrote:
>=20
> On Wed, Jul 20, 2016 at 07:40:49PM +0200, Thomas Monjalon wrote:
>> 2016-07-20 13:09, Neil Horman:
>>> From: Neil Horman <nhorman@redhat.com>
>>>=20
>>> John Mcnamara and I were discussing enhacing the validate_abi script to=
 build
>>> the dpdk tree faster with multiple jobs.  Theres no reason not to do it=
, so this
>>> implements that requirement.  It uses a MAKE_JOBS variable that can be =
set by
>>> the user to limit the job count.  By default the job count is set to th=
e number
>>> of online cpus.
>>=20
>> Please could you use the variable name DPDK_MAKE_JOBS?
>> This name is already used in scripts/test-build.sh.
>>=20
> Sure
>=20
>>> +if [ -z "$MAKE_JOBS" ]
>>> +then
>>> +	# This counts the number of cpus on the system
>>> +	MAKE_JOBS=3D`lscpu -p=3Dcpu | grep -v "#" | wc -l`
>>> +fi
>>=20
>> Is lscpu common enough?
>>=20
> I'm not sure how to answer that.  lscpu is part of the util-linux package=
, which
> is part of any base install.  Theres a variant for BSD, but I'm not sure =
how
> common it is there.
> Neil
>=20
>> Another acceptable default would be just "-j" without any number.
>> It would make the number of jobs unlimited.

I think the best is just use -j as it tries to use the correct number of jo=
bs based on the number of cores, right?