From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sanford, Robert" Subject: Re: [PATCH 3/6] bond: fix naming inconsistency in tx_burst_round_robin Date: Wed, 20 Aug 2014 15:25:57 -0500 Message-ID: References: <1408456313-28812-1-git-send-email-declan.doherty@intel.com> <1408456313-28812-4-git-send-email-declan.doherty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: Declan Doherty , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <1408456313-28812-4-git-send-email-declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Reviewed-by: Robert Sanford >Renaming struct bond_dev_pritvate *dev_private to internals to match >convention used in other pmds > >Signed-off-by: Declan Doherty >--- > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c >b/lib/librte_pmd_bond/rte_eth_bond_pmd.c >index 683b146..70123fc 100644 >--- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c >+++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c >@@ -92,7 +92,7 @@ static uint16_t > bond_ethdev_tx_burst_round_robin(void *queue, struct rte_mbuf **bufs, > uint16_t nb_pkts) > { >- struct bond_dev_private *dev_private; >+ struct bond_dev_private *internals; > struct bond_tx_queue *bd_tx_q; >=20 > struct rte_mbuf *slave_bufs[RTE_MAX_ETHPORTS][nb_pkts]; >@@ -107,13 +107,13 @@ bond_ethdev_tx_burst_round_robin(void *queue, >struct rte_mbuf **bufs, > int i, cs_idx =3D 0; >=20 > bd_tx_q =3D (struct bond_tx_queue *)queue; >- dev_private =3D bd_tx_q->dev_private; >+ internals =3D bd_tx_q->dev_private; >=20 > /* Copy slave list to protect against slave up/down changes during tx > * bursting */ >- num_of_slaves =3D dev_private->active_slave_count; >- memcpy(slaves, dev_private->active_slaves, >- sizeof(dev_private->active_slaves[0]) * num_of_slaves); >+ num_of_slaves =3D internals->active_slave_count; >+ memcpy(slaves, internals->active_slaves, >+ sizeof(internals->active_slaves[0]) * num_of_slaves); >=20 > if (num_of_slaves < 1) > return num_tx_total; >--=20 >1.7.0.7 >