From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sanford, Robert" <rsanford-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/2] igb_uio: fix compability on old kernel
Date: Tue, 26 Aug 2014 11:08:53 -0500
Message-ID: <D0222750.29B5%rsanford@akamai.com>
References: <20140725103627.4ca989b7@haswell.linuxnetplumber.net>
 <9317787.qKVt3oyQbN@xps13> <D01CF3B4.28B5%rsanford@akamai.com>
 <CA+cr1coJs9yokaDT1ya=5ChSWuSYWiF4TqmAhpcP0qLZKC4odA@mail.gmail.com>
 <20140823081453.6e3ae5d7@uryu.home.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <20140823081453.6e3ae5d7-CA4OZQ/Yy2Lykuyl+CZolw@public.gmane.org>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>


>
>> This is what we came up with. It works for us. In our kernel headers'
>> linux/pci.h, pci_num_vf is enclosed within "#ifdef
>>CONFIG_PCI_IOV/#endif";
>> pci_intx_mask_supported and pci_check_and_mask_intx are enclosed within
>> "#ifdef HAVE_PCI_SET_MWI/#endif".
>>=20
>> What do you think?
>
>Maybe we can just get rid of kernel version checks all together and
>just use the HAVE_ checks.
>
>I will test on stock 2.6.32.

Sorry, I spoke too soon. Although it builds with the ifdefs, I just found
that it does not load.
"kernel: igb_uio: Unknown symbol irq_to_desc"