From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sujith Sankar (ssujith)" <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3 6/6] DPDK changes for accommodating ENIC
 PMD
Date: Mon, 24 Nov 2014 15:51:02 +0000
Message-ID: <D0995111.28833%ssujith@cisco.com>
References: <1416758899-1351-1-git-send-email-ssujith@cisco.com>
 <1416758899-1351-7-git-send-email-ssujith@cisco.com>
 <CALwxeUsQ4=jW-OB_AqXVHL8Rx7sAJt+qn8yTYDuW9j-r=e+afw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>, "Prasad Rao \(prrao\)" <prrao-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <CALwxeUsQ4=jW-OB_AqXVHL8Rx7sAJt+qn8yTYDuW9j-r=e+afw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi David,

During the testing, I saw that the length field was 0.  ENIC PMD validates =
the length of the BAR against a max value.
In order to get the length in the resource structure, I added this statemen=
t.

Thanks,
-Sujith

From: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org<mailto:david.marchand@6wind.=
com>>
Date: Monday, 24 November 2014 4:33 pm
To: "Sujith Sankar (ssujith)" <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org<mailto:ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>>
Cc: "dev-VfR2kkLFssw@public.gmane.org<mailto:dev-VfR2kkLFssw@public.gmane.org>" <dev-VfR2kkLFssw@public.gmane.org<mailto:dev-VfR2kkLFssw@public.gmane.org>>=
, "Prasad Rao (prrao)" <prrao-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org<mailto:prrao-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>>
Subject: Re: [dpdk-dev] [PATCH v3 6/6] DPDK changes for accommodating ENIC =
PMD

Hello Sujith,

On Sun, Nov 23, 2014 at 5:08 PM, Sujith Sankar <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org<mailto:ss=
ujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>> wrote:
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/li=
nuxapp/eal/eal_pci_vfio.c
index c776ddc..6bf8f2e 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
@@ -736,6 +736,7 @@ pci_vfio_map_resource(struct rte_pci_device *dev)
                maps[i].offset =3D reg.offset;
                maps[i].size =3D reg.size;
                dev->mem_resource[i].addr =3D bar_addr;
+               dev->mem_resource[i].len =3D reg.size;
        }

        /* if secondary process, do not set up interrupts */

Not sure I understand why you need to overwrite the length value.
This is supposed to be initialised before by "generic" code.
This looks like a hack or a workaround.

Can you elaborate on this change ?
Thanks.


--
David Marchand