From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sujith Sankar (ssujith)" Subject: Re: [PATCH v4 6/6] DPDK changes for accommodating ENIC PMD Date: Tue, 25 Nov 2014 10:46:17 +0000 Message-ID: References: <1416933018-23415-1-git-send-email-ssujith@cisco.com> <1416933018-23415-7-git-send-email-ssujith@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" , "Prasad Rao \(prrao\)" To: David Marchand Return-path: In-Reply-To: Content-Language: en-US Content-ID: <064A4C398FFC8C4AB54BB66E314E7AC4-WwaMAgPkaIIluPl5bxqUMw@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" David, I tested it now, and it looks like the length is proper in dev->men_resource[0].len without this change. Not sure what changed in my workspace as I clearly remember seeing it wrong and hence added the extra statement in the lib. I shall remove it in v5. Thanks for pointing it out, David. Regards, -Sujith =20 From: David Marchand Date: Tuesday, 25 November 2014 3:32 pm To: "Sujith Sankar (ssujith)" Cc: "dev-VfR2kkLFssw@public.gmane.org" , "Prasad Rao (prrao)" Subject: Re: [dpdk-dev] [PATCH v4 6/6] DPDK changes for accommodating ENIC PMD Hello Sujith,=20 On Tue, Nov 25, 2014 at 5:30 PM, Sujith Sankar wrote: diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c index c776ddc..87e7862 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c @@ -736,6 +736,7 @@ pci_vfio_map_resource(struct rte_pci_device *dev) maps[i].offset =3D reg.offset; maps[i].size =3D reg.size; dev->mem_resource[i].addr =3D bar_addr; + dev->mem_resource[i].len =3D reg.size; } /* if secondary process, do not set up interrupts */ I still think this part is wrong. The length should have been populated by pci_parse_sysfs_resource(). Are you sure this length is 0 ? Can you do give me the result of cat /sys/bus/pci/devices/$your_device_pci_address/resource ? Thanks. --=20 David Marchand