From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sujith Sankar (ssujith)" <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] enicpmd: compilation error during inclusion
	of vfio.h
Date: Thu, 27 Nov 2014 17:22:31 +0000
Message-ID: <D09D5B5D.28F99%ssujith@cisco.com>
References: <1417108480-28341-1-git-send-email-ssujith@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1417108480-28341-1-git-send-email-ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Content-Language: en-US
Content-ID: <1F93DD0C5FBB8646A266744B7E3C9E4D-WwaMAgPkaIIluPl5bxqUMw@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>



On 27/11/14 10:44 pm, "Sujith Sankar (ssujith)" <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> wrote:

>Inclusion of vfio.h was giving compilation errors if kernel version is
>less
>than 3.6.0 and if RTE_EAL_VFIO was on in config.
>
>Replaced inclusion of vfio.h with eal_vfio.h and replaced RTE_EAL_VFIO
>with
>VFIO_PRESENT in enicpmd code.

eal_vfio.h is not included.  The inclusion of vfio.h is removed.  Sorry
for the error in the description.


>
>Signed-off-by: Sujith Sankar <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
>---
> lib/librte_pmd_enic/Makefile    |  1 +
> lib/librte_pmd_enic/enic_main.c | 13 +++++--------
> 2 files changed, 6 insertions(+), 8 deletions(-)
>
>diff --git a/lib/librte_pmd_enic/Makefile b/lib/librte_pmd_enic/Makefile
>index d4c2f66..befc552 100644
>--- a/lib/librte_pmd_enic/Makefile
>+++ b/lib/librte_pmd_enic/Makefile
>@@ -39,6 +39,7 @@ LIB =3D librte_pmd_enic.a
>=20
> CFLAGS +=3D -I$(RTE_SDK)/lib/librte_hash/
>-I$(RTE_SDK)/lib/librte_pmd_enic/vnic/
> CFLAGS +=3D -I$(RTE_SDK)/lib/librte_pmd_enic/
>+CFLAGS +=3D -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/
> CFLAGS +=3D -O3 -Wno-deprecated
>=20
> VPATH +=3D $(RTE_SDK)/lib/librte_pmd_enic/src
>diff --git a/lib/librte_pmd_enic/enic_main.c
>b/lib/librte_pmd_enic/enic_main.c
>index 4b857bb..f6f00d3 100644
>--- a/lib/librte_pmd_enic/enic_main.c
>+++ b/lib/librte_pmd_enic/enic_main.c
>@@ -39,9 +39,6 @@
> #include <sys/mman.h>
> #include <fcntl.h>
> #include <libgen.h>
>-#ifdef RTE_EAL_VFIO
>-#include <linux/vfio.h>
>-#endif
>=20
> #include <rte_pci.h>
> #include <rte_memzone.h>
>@@ -631,7 +628,7 @@ int enic_enable(struct enic *enic)
>=20
> 	vnic_dev_enable_wait(enic->vdev);
>=20
>-#ifndef RTE_EAL_VFIO
>+#ifndef VFIO_PRESENT
> 	/* Register and enable error interrupt */
> 	rte_intr_callback_register(&(enic->pdev->intr_handle),
> 		enic_intr_handler, (void *)enic->rte_dev);
>@@ -995,7 +992,7 @@ int enic_setup_finish(struct enic *enic)
> 	return 0;
> }
>=20
>-#ifdef RTE_EAL_VFIO
>+#ifdef VFIO_PRESENT
> static void enic_eventfd_init(struct enic *enic)
> {
> 	enic->eventfd =3D enic->pdev->intr_handle.fd;
>@@ -1033,7 +1030,7 @@ int enic_get_link_status(struct enic *enic)
> }
>=20
>=20
>-#ifdef RTE_EAL_VFIO
>+#ifdef VFIO_PRESENT
> static int enic_create_err_intr_thread(struct enic *enic)
> {
> 	pthread_attr_t intr_attr;
>@@ -1111,7 +1108,7 @@ static void enic_dev_deinit(struct enic *enic)
> 	if (eth_dev->data->mac_addrs)
> 		rte_free(eth_dev->data->mac_addrs);
>=20
>-#ifdef RTE_EAL_VFIO
>+#ifdef VFIO_PRESENT
> 	enic_clear_intr_mode(enic);
> #endif
> }
>@@ -1167,7 +1164,7 @@ static int enic_dev_init(struct enic *enic)
> 	*/
> 	enic_get_res_counts(enic);
>=20
>-#ifdef RTE_EAL_VFIO
>+#ifdef VFIO_PRESENT
> 	/* Set interrupt mode based on resource counts and system
> 	 * capabilities
> 	 */
>--=20
>1.9.1
>