From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sujith Sankar (ssujith)" <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] enicpmd: compilation error during inclusion
 of vfio.h
Date: Fri, 28 Nov 2014 02:31:41 +0000
Message-ID: <D09DDC03.28FC9%ssujith@cisco.com>
References: <1417108480-28341-1-git-send-email-ssujith@cisco.com>
 <2232586.GRrg2Bq1yj@xps13> <3873403.PSCWCNKvtK@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <3873403.PSCWCNKvtK@xps13>
Content-Language: en-US
Content-ID: <42E7832C531103438714ACE4197E63CB-WwaMAgPkaIIluPl5bxqUMw@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>



On 28/11/14 1:54 am, "Thomas Monjalon" <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> wrote:

>2014-11-27 19:01, Thomas Monjalon:
>> 2014-11-27 22:44, Sujith Sankar:
>> > Inclusion of vfio.h was giving compilation errors if kernel version
>>is less
>> > than 3.6.0 and if RTE_EAL_VFIO was on in config.
>> >=20
>> > Replaced inclusion of vfio.h with eal_vfio.h and replaced
>>RTE_EAL_VFIO with
>> > VFIO_PRESENT in enicpmd code.
>>=20
>> You should add
>> Reported-by: Pawel Wodkowski <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

I shall take care of this from now on.

>>=20
>> > Signed-off-by: Sujith Sankar <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
>> [...]
>> >  CFLAGS +=3D -I$(RTE_SDK)/lib/librte_hash/
>>-I$(RTE_SDK)/lib/librte_pmd_enic/vnic/
>> >  CFLAGS +=3D -I$(RTE_SDK)/lib/librte_pmd_enic/
>> > +CFLAGS +=3D -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/
>> >  CFLAGS +=3D -O3 -Wno-deprecated
>>=20
>> I think -I$(RTE_SDK)/lib/librte_hash/ and
>>-I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/
>> are not needed.
>>=20
>> I'll fix it if you confirm.

You=B9re right.

>
>Applied with above comments.

Thank you Thomas !

>
>--=20
>Thomas