From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sujith Sankar (ssujith)" Subject: Re: [PATCH] enic: fix warnings Date: Wed, 3 Dec 2014 15:10:05 +0000 Message-ID: References: <1417532360-8568-1-git-send-email-thomas.monjalon@6wind.com> <2126129.v20IaaVbE9@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: <2126129.v20IaaVbE9@xps13> Content-Language: en-US Content-ID: <3B59D9BD11ED024EACECE7AC84FE0AF3-WwaMAgPkaIIluPl5bxqUMw@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 03/12/14 8:35 pm, "Thomas Monjalon" wrote: >2014-12-03 14:52, Sujith Sankar: >>=20 >> On 02/12/14 8:29 pm, "Thomas Monjalon" >>wrote: >>=20 >> >A lot of warnings were not seen because $(WERROR_FLAGS) was not set >> >in the Makefile. But they appear with toolchains that enforce more >>checks. >> > >> >-Wno-deprecated seems useless. >> >-Wno-strict-aliasing is added to avoid false positives. >> > >> >This patch cleans up unused variable, unused functions, wrong types, >> >static declarations, etc. A lot of functions have unused parameters; >> >it suggests that more clean-up could be needed. >>=20 >> I shall look at it when I pull these changes to my repo. >> What other toolchains did you check with? > >It's tested with many distributions, example CentOS 6. >But adding the warnings as in this patch should be enough to test with >any toolchain. Thanks Thomas. I shall look at the unused vars and get back with clean-up patch. Your patch looks good. And I did a quick sanity test on my server, which went through fine. -Sujith > >--=20 >Thomas