From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sujith Sankar (ssujith)" Subject: Re: [PATCH] enic: fix warnings Date: Thu, 4 Dec 2014 10:58:17 +0000 Message-ID: References: <1417532360-8568-1-git-send-email-thomas.monjalon@6wind.com> <2887963.q9hPn3S3sv@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: <2887963.q9hPn3S3sv@xps13> Content-Language: en-US Content-ID: <17EEC930AB802D4DBCB36E81E4CFCC4D-WwaMAgPkaIIluPl5bxqUMw@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 04/12/14 4:18 pm, "Thomas Monjalon" wrote: >2014-12-04 10:29, Sujith Sankar: >>=20 >> On 02/12/14 8:29 pm, "Thomas Monjalon" >>wrote: >>=20 >> >A lot of warnings were not seen because $(WERROR_FLAGS) was not set >> >in the Makefile. But they appear with toolchains that enforce more >>checks. >> > >> >-Wno-deprecated seems useless. >> >-Wno-strict-aliasing is added to avoid false positives. >> > >> >This patch cleans up unused variable, unused functions, wrong types, >> >static declarations, etc. A lot of functions have unused parameters; >> >it suggests that more clean-up could be needed. >> > >> >Signed-off-by: Thomas Monjalon >> >--- >> > lib/librte_pmd_enic/Makefile | 3 +- >> > lib/librte_pmd_enic/enic.h | 4 +- >> > lib/librte_pmd_enic/enic_ethdev.c | 20 ++++----- >>=20 >> Thomas, the name of this file got modified. It was enic_etherdev.c in >>my >> submission. >> Any idea how this happened? I do not remember seeing a request for >>this. > >Yes, sorry I forgot to request it. >I renamed the file to be consistent with other drivers. >Everywhere in DPDK we talk about ethdev for device operations, not >etherdev. Ok.=20 Thank you. > >--=20 >Thomas