From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sujith Sankar (ssujith)" <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] enic: corrected the usage of VFIO_PRESENT
Date: Tue, 16 Dec 2014 04:12:41 +0000
Message-ID: <D0B5AE42.2A9E2%ssujith@cisco.com>
References: <1418372303-31565-1-git-send-email-ssujith@cisco.com>
 <5911790.4rCTPaIceN@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <5911790.4rCTPaIceN@xps13>
Content-Language: en-US
Content-ID: <A20FBF2AE24F084E80BFAC21AE83A032-WwaMAgPkaIIluPl5bxqUMw@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>


On 16/12/14 4:54 am, "Thomas Monjalon" <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> wrote:

>2014-12-12 13:48, Sujith Sankar:
>> This patch corrects the usage of the flag VFIO_PRESENT in enic driver.
>
>Please, could you explain why the flag VFIO_PRESENT was not well used?

Without including eal_vfio.h, VFIO_PRESENT is not available in enic.
Hence VFIO specific code in enic was not getting compiled and some errors
were generated during run-time.

>
>> This has uncovered a few warnings, and this patch corrects those too.
>[...]
>> --- a/lib/librte_pmd_enic/enic_main.c
>> +++ b/lib/librte_pmd_enic/enic_main.c
>> @@ -39,6 +39,7 @@
>>  #include <sys/mman.h>
>>  #include <fcntl.h>
>>  #include <libgen.h>
>> +#include <sys/ioctl.h>
>> =20
>>  #include <rte_pci.h>
>>  #include <rte_memzone.h>
>> @@ -46,6 +47,7 @@
>>  #include <rte_mbuf.h>
>>  #include <rte_string_fns.h>
>>  #include <rte_ethdev.h>
>> +#include <eal_vfio.h>
>
>This header was not designed to be included by PMDs.
>It will break compilation on BSD.

Is there an alternative to make VFIO_PRESENT available in enic?  Please
advise.

Thanks,
-Sujith

>
>>  #include "enic_compat.h"
>>  #include "enic.h"
>> @@ -561,6 +563,7 @@ enic_free_consistent(__rte_unused struct
>>rte_pci_device *hwdev,
>>  	/* Nothing to be done */
>>  }
>> =20
>> +#ifndef VFIO_PRESENT
>>  static void
>>  enic_intr_handler(__rte_unused struct rte_intr_handle *handle,
>>  	void *arg)
>> @@ -572,6 +575,7 @@ enic_intr_handler(__rte_unused struct
>>rte_intr_handle *handle,
>> =20
>>  	enic_log_q_error(enic);
>>  }
>> +#endif
>
>--=20
>Thomas