From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sujith Sankar (ssujith)" <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] enic: corrected the usage of VFIO_PRESENT
Date: Tue, 16 Dec 2014 10:34:06 +0000
Message-ID: <D0B6061A.2ABCF%ssujith@cisco.com>
References: <1418372303-31565-1-git-send-email-ssujith@cisco.com>
 <5911790.4rCTPaIceN@xps13> <D0B5AE42.2A9E2%ssujith@cisco.com>
 <C6ECDF3AB251BE4894318F4E4512369780C259D2@IRSMSX109.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: "Burakov, Anatoly" <anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Thomas Monjalon
 <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <C6ECDF3AB251BE4894318F4E4512369780C259D2-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Content-Language: en-US
Content-ID: <A59817807E8AF446B058308DD7337570-WwaMAgPkaIIluPl5bxqUMw@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>



On 16/12/14 3:52 pm, "Burakov, Anatoly" <anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:

>> On 16/12/14 4:54 am, "Thomas Monjalon" <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
>> wrote:
>>=20
>> >2014-12-12 13:48, Sujith Sankar:
>> >> This patch corrects the usage of the flag VFIO_PRESENT in enic
>>driver.
>> >
>> >Please, could you explain why the flag VFIO_PRESENT was not well used?
>>=20
>> Without including eal_vfio.h, VFIO_PRESENT is not available in enic.
>> Hence VFIO specific code in enic was not getting compiled and some
>>errors
>> were generated during run-time.
>>=20
>> >
>> >> This has uncovered a few warnings, and this patch corrects those too.
>> >[...]
>> >> --- a/lib/librte_pmd_enic/enic_main.c
>> >> +++ b/lib/librte_pmd_enic/enic_main.c
>> >> @@ -39,6 +39,7 @@
>> >>  #include <sys/mman.h>
>> >>  #include <fcntl.h>
>> >>  #include <libgen.h>
>> >> +#include <sys/ioctl.h>
>> >>
>> >>  #include <rte_pci.h>
>> >>  #include <rte_memzone.h>
>> >> @@ -46,6 +47,7 @@
>> >>  #include <rte_mbuf.h>
>> >>  #include <rte_string_fns.h>
>> >>  #include <rte_ethdev.h>
>> >> +#include <eal_vfio.h>
>> >
>> >This header was not designed to be included by PMDs.
>> >It will break compilation on BSD.
>>=20
>> Is there an alternative to make VFIO_PRESENT available in enic?  Please
>> advise.
>>=20
>> Thanks,
>> -Sujith
>>=20
>> >
>> >>  #include "enic_compat.h"
>> >>  #include "enic.h"
>> >> @@ -561,6 +563,7 @@ enic_free_consistent(__rte_unused struct
>> >>rte_pci_device *hwdev,
>> >>  	/* Nothing to be done */
>> >>  }
>> >>
>> >> +#ifndef VFIO_PRESENT
>> >>  static void
>> >>  enic_intr_handler(__rte_unused struct rte_intr_handle *handle,
>> >>  	void *arg)
>> >> @@ -572,6 +575,7 @@ enic_intr_handler(__rte_unused struct
>> >>rte_intr_handle *handle,
>> >>
>> >>  	enic_log_q_error(enic);
>> >>  }
>> >> +#endif
>> >
>> >--
>> >Thomas
>
>Hi Sujith
>
>Thomas is correct, VFIO code is designed to be EAL-only (mainly because
>it's Linuxapp-specific, and PMD's are intended to be cross-platform at
>least when it comes to compilation). Whatever it is that you're working
>around is better fixed in the EAL itself rather than in the PMD.

I agree with you and Thomas.  Let me find the root cause for the false
trigger.=20

Thanks,
-Sujith

>
>Thanks,
>Anatoly