* [PATCH] enic: silence log message
@ 2015-02-08 17:36 Stephen Hemminger
[not found] ` <1423416981-5168-1-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2015-02-08 17:36 UTC (permalink / raw)
To: dev-VfR2kkLFssw; +Cc: Stephen Hemminger
From: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
Silence is normal. drivers should speak only when spoken to and not
be chatty.
Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
---
lib/librte_pmd_enic/enic_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c
index 48fdca2..dad8922 100644
--- a/lib/librte_pmd_enic/enic_main.c
+++ b/lib/librte_pmd_enic/enic_main.c
@@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic)
struct rte_pci_device *pdev = enic->pdev;
int err = -1;
- dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
-
enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
enic->bar0.len = pdev->mem_resource[0].len;
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread[parent not found: <1423416981-5168-1-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>]
* [PATCH] enic: silence log message [not found] ` <1423416981-5168-1-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> @ 2015-02-08 17:36 ` Stephen Hemminger [not found] ` <1423416981-5168-2-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Stephen Hemminger @ 2015-02-08 17:36 UTC (permalink / raw) To: dev-VfR2kkLFssw; +Cc: Stephen Hemminger From: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org> Silence is normal. drivers should speak only when spoken to and not be chatty. Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> --- lib/librte_pmd_enic/enic_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c index 48fdca2..dad8922 100644 --- a/lib/librte_pmd_enic/enic_main.c +++ b/lib/librte_pmd_enic/enic_main.c @@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic) struct rte_pci_device *pdev = enic->pdev; int err = -1; - dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION); - enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr; enic->bar0.len = pdev->mem_resource[0].len; -- 2.1.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <1423416981-5168-2-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>]
* Re: [PATCH] enic: silence log message [not found] ` <1423416981-5168-2-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> @ 2015-02-09 12:21 ` David Marchand [not found] ` <CALwxeUt87snj1=fbc4UyV9fbR_aYUN5FmU2v7tF3CBrk4M3OEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: David Marchand @ 2015-02-09 12:21 UTC (permalink / raw) To: Stephen Hemminger; +Cc: dev-VfR2kkLFssw@public.gmane.org, Stephen Hemminger On Sun, Feb 8, 2015 at 6:36 PM, Stephen Hemminger < stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> wrote: > From: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org> > > Silence is normal. drivers should speak only when spoken to and not > be chatty. > > Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> > --- > lib/librte_pmd_enic/enic_main.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/librte_pmd_enic/enic_main.c > b/lib/librte_pmd_enic/enic_main.c > index 48fdca2..dad8922 100644 > --- a/lib/librte_pmd_enic/enic_main.c > +++ b/lib/librte_pmd_enic/enic_main.c > @@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic) > struct rte_pci_device *pdev = enic->pdev; > int err = -1; > > - dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION); > - > enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr; > enic->bar0.len = pdev->mem_resource[0].len; > NAK. The main problem is that enic pmd is using printf to write logs. So the pmd should be fixed so that dev_* macros use RTE_LOG. Silence is good when it is the default behaviour. But I prefer we can change this at runtime, rather than strip the log messages, especially for init. -- David Marchand ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CALwxeUt87snj1=fbc4UyV9fbR_aYUN5FmU2v7tF3CBrk4M3OEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] enic: silence log message [not found] ` <CALwxeUt87snj1=fbc4UyV9fbR_aYUN5FmU2v7tF3CBrk4M3OEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2015-02-09 16:11 ` Stephen Hemminger [not found] ` <CAOaVG17Zjw1S+rG3pMh2eGjYGaD6tQw6-4zETU-dW=MpPsmoGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Stephen Hemminger @ 2015-02-09 16:11 UTC (permalink / raw) To: David Marchand; +Cc: dev-VfR2kkLFssw, Stephen Hemminger Agree it should not use printf. If you insist on keeping the useless message then it should be log level debug ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CAOaVG17Zjw1S+rG3pMh2eGjYGaD6tQw6-4zETU-dW=MpPsmoGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] enic: silence log message [not found] ` <CAOaVG17Zjw1S+rG3pMh2eGjYGaD6tQw6-4zETU-dW=MpPsmoGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2015-02-15 6:13 ` Sujith Sankar (ssujith) [not found] ` <D1063669.2FCE5%ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Sujith Sankar (ssujith) @ 2015-02-15 6:13 UTC (permalink / raw) To: Stephen Hemminger, David Marchand; +Cc: dev-VfR2kkLFssw@public.gmane.org Hi Stephen, David, I agree with you and shall submit this change. Thanks, -Sujith On 09/02/15 9:41 pm, "Stephen Hemminger" <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> wrote: >Agree it should not use printf. >If you insist on keeping the useless message then it should be log level >debug ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <D1063669.2FCE5%ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] enic: silence log message [not found] ` <D1063669.2FCE5%ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> @ 2015-02-15 6:29 ` Sujith Sankar (ssujith) 0 siblings, 0 replies; 7+ messages in thread From: Sujith Sankar (ssujith) @ 2015-02-15 6:29 UTC (permalink / raw) To: Stephen Hemminger, David Marchand; +Cc: dev-VfR2kkLFssw@public.gmane.org Stephen, Saw your patch. Will take a look. Thanks, -Sujith On 15/02/15 11:43 am, "Sujith Sankar (ssujith)" <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> wrote: >Hi Stephen, David, > >I agree with you and shall submit this change. > >Thanks, >-Sujith > >On 09/02/15 9:41 pm, "Stephen Hemminger" <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> >wrote: > >>Agree it should not use printf. >>If you insist on keeping the useless message then it should be log level >>debug > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] enic: silence log message @ 2015-02-08 17:35 Stephen Hemminger 0 siblings, 0 replies; 7+ messages in thread From: Stephen Hemminger @ 2015-02-08 17:35 UTC (permalink / raw) To: dev-VfR2kkLFssw; +Cc: Stephen Hemminger From: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org> Silence is normal. drivers should speak only when spoken to and not be chatty. Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> --- lib/librte_pmd_enic/enic_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c index 48fdca2..dad8922 100644 --- a/lib/librte_pmd_enic/enic_main.c +++ b/lib/librte_pmd_enic/enic_main.c @@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic) struct rte_pci_device *pdev = enic->pdev; int err = -1; - dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION); - enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr; enic->bar0.len = pdev->mem_resource[0].len; -- 2.1.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-02-15 6:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 17:36 [PATCH] enic: silence log message Stephen Hemminger
[not found] ` <1423416981-5168-1-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-08 17:36 ` Stephen Hemminger
[not found] ` <1423416981-5168-2-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-09 12:21 ` David Marchand
[not found] ` <CALwxeUt87snj1=fbc4UyV9fbR_aYUN5FmU2v7tF3CBrk4M3OEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-09 16:11 ` Stephen Hemminger
[not found] ` <CAOaVG17Zjw1S+rG3pMh2eGjYGaD6tQw6-4zETU-dW=MpPsmoGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-15 6:13 ` Sujith Sankar (ssujith)
[not found] ` <D1063669.2FCE5%ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2015-02-15 6:29 ` Sujith Sankar (ssujith)
-- strict thread matches above, loose matches on Subject: below --
2015-02-08 17:35 Stephen Hemminger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).