From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wiles, Keith" <keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: fm10k_rxtx.c does not compile
Date: Wed, 18 Feb 2015 17:29:02 +0000
Message-ID: <D10A27E5.13C8E%keith.wiles@intel.com>
References: <D10A2192.13C81%keith.wiles@intel.com> <4252267.lcD9EdtIU9@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <4252267.lcD9EdtIU9@xps13>
Content-Language: en-US
Content-ID: <E0F9FDD377BD0F458CDDA08951161DBA-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

I believe Jeff @ Intel is going to submit a patch soon.


On 2/18/15, 11:18 AM, "Thomas Monjalon" <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> wrote:

>Hi Keith,
>
>2015-02-18 17:01, Wiles, Keith:
>> I just pulled the code and found a unused function error =8Cdump_rxd()=
=B9
>>=20
>> I had to add the ifdef around the function and remove the ifdef inside
>>the function:
>>=20
>> #ifdef RTE_LIBRTE_FM10K_DEBUG_RX
>> static inline void dump_rxd(union fm10k_rx_desc *rxd)
>> {
>> RTE_SET_USED(rxd);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "|     GLORT      | PKT HDR & TYPE |");
>> PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", rxd->d.glort,
>> rxd->d.data);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "|   VLAN & LEN   |     STATUS     |");
>> PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", rxd->d.vlan_len,
>> rxd->d.staterr);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "|    RESERVED    |    RSS_HASH    |");
>> PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", 0, rxd->d.rss);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "|            TIME TAG             |");
>> PMD_RX_LOG(DEBUG, "|       0x%016lx        |", rxd->q.timestamp);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> }
>> #endif
>>=20
>> Also clang on Ubuntu 14.04 does not like the option:
>>   CC fm10k_pf.o
>> error: unknown warning option '-Wno-unused-but-set-variable'; did you
>>mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option]
>
>Thanks for reporting.
>I have no error with GCC 4.9.2.
>Please could you try to send a patch?