From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: tools brainstorming Date: Tue, 14 Apr 2015 16:19:37 +0000 Message-ID: References: <3571725.20GtF5MAnU@xps13> <2232884.6IKBPajdgE@xps13> <20150414145255.GC3296@bricha3-MOBL3> <1483348.C8YyOOilOR@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon , "Richardson, Bruce" Return-path: In-Reply-To: <1483348.C8YyOOilOR@xps13> Content-Language: en-US Content-ID: <31F7D0E60ABD7042BDA9881D0B62F3B1-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 4/14/15, 10:24 AM, "Thomas Monjalon" wrote: >2015-04-14 15:52, Bruce Richardson: >> On Wed, Apr 08, 2015 at 06:16:12PM +0200, Thomas Monjalon wrote: >> > When a consensus is done, it must be added with a patch with custom >> > checkpatch addition. >> >=20 >> My personal feeling is that we should try and keep checkpatch >>modifications to a >> minimum. Right now, we can use checkpatch as-is from kernel.org, right? > >Yes that's something we have to discuss. >It should be preferred to avoid "forking" checkpatch. > >At the moment, I'm using this configuration: > > options=3D"$options --max-line-length=3D100" > options=3D"$options --show-types" > options=3D"$options --ignore=3DLINUX_VERSION_CODE,FILE_PATH_CHANGES,\ > VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > SPLIT_STRING,LINE_SPACING,NEW_TYPEDEFS,COMPLEX_MACRO" > > linux/scripts/checkpatch.pl $options > >I would like to submit a script to run checkpatch with DPDK configuration >when the coding rules are clear. > >However, I've already seen some options which are not enough configurable >(don't remember which one). For such corner case, I would see 3 solutions >(from the most to the least desired): > - submit a patch to allow more configuration to kernel.org > - give up automatic handling of corner cases > - maintain a fork in scripts/ directory Here is the next solution - Stop using checkpatch and use a real tool for formatting code instead. If someone uses a tool before commit, then create the patch which does not require checkpatch. Most of these tools can define an output file or they leave behind the original file as a backup or we can see if they have a non-modify mode and just points out the problems. As in astyle '--dry-run' can be used, plus it saves the original file as XXXXX.orig or you can change the .orig to your own value. >