From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sujith Sankar (ssujith)" Subject: Re: [PATCH] enic: set correct port ID in received mbufs Date: Sat, 18 Apr 2015 17:49:30 +0000 Message-ID: References: <1429021435-28414-1-git-send-email-adrien.mazarguil@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: Adrien Mazarguil , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <1429021435-28414-1-git-send-email-adrien.mazarguil-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> Content-Language: en-US Content-ID: <0D2AEB077993AD49B93FCF520A55B238-WwaMAgPkaIIluPl5bxqUMw@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 14/04/15 7:53 pm, "Adrien Mazarguil" wrote: >This field is not supposed to contain the RX queue index. Applications can >rely on it to determine the port a given mbuf comes from. > >Signed-off-by: Adrien Mazarguil >--- > lib/librte_pmd_enic/enic.h | 1 + > lib/librte_pmd_enic/enic_ethdev.c | 1 + > lib/librte_pmd_enic/enic_main.c | 4 ++-- > 3 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/lib/librte_pmd_enic/enic.h b/lib/librte_pmd_enic/enic.h >index a50bff1..0eba334 100644 >--- a/lib/librte_pmd_enic/enic.h >+++ b/lib/librte_pmd_enic/enic.h >@@ -99,6 +99,7 @@ struct enic { > struct vnic_dev_bar bar0; > struct vnic_dev *vdev; >=20 >+ unsigned int port_id; > struct rte_eth_dev *rte_dev; > struct enic_fdir fdir; > char bdf_name[ENICPMD_BDF_LENGTH]; >diff --git a/lib/librte_pmd_enic/enic_ethdev.c >b/lib/librte_pmd_enic/enic_ethdev.c >index 3e53f86..a319e1e 100644 >--- a/lib/librte_pmd_enic/enic_ethdev.c >+++ b/lib/librte_pmd_enic/enic_ethdev.c >@@ -567,6 +567,7 @@ static int eth_enicpmd_dev_init(struct rte_eth_dev >*eth_dev) >=20 > ENICPMD_FUNC_TRACE(); >=20 >+ enic->port_id =3D eth_dev->data->port_id; > enic->rte_dev =3D eth_dev; > eth_dev->dev_ops =3D &enicpmd_eth_dev_ops; > eth_dev->rx_pkt_burst =3D &enicpmd_recv_pkts; >diff --git a/lib/librte_pmd_enic/enic_main.c >b/lib/librte_pmd_enic/enic_main.c >index 0e40d46..15313c2 100644 >--- a/lib/librte_pmd_enic/enic_main.c >+++ b/lib/librte_pmd_enic/enic_main.c >@@ -344,7 +344,7 @@ static int enic_rq_alloc_buf(struct vnic_rq *rq) > hdr_mbuf->data_off =3D RTE_PKTMBUF_HEADROOM; >=20 > hdr_mbuf->nb_segs =3D 2; >- hdr_mbuf->port =3D rq->index; >+ hdr_mbuf->port =3D enic->port_id; > hdr_mbuf->next =3D mbuf; >=20 > dma_addr =3D (dma_addr_t) >@@ -359,7 +359,7 @@ static int enic_rq_alloc_buf(struct vnic_rq *rq) > type =3D RQ_ENET_TYPE_NOT_SOP; > } else { > mbuf->nb_segs =3D 1; >- mbuf->port =3D rq->index; >+ mbuf->port =3D enic->port_id; > } >=20 > mbuf->data_off =3D RTE_PKTMBUF_HEADROOM; >--=20 >2.1.0 Acked-by: Sujith Sankar Thanks, -Sujith >