From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: Small request for patch review in DPDK Date: Wed, 27 May 2015 14:39:57 +0000 Message-ID: References: <55655D3D.8070208@netinsight.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: =?iso-8859-1?Q?Simon_K=E5gstr=F6m?= , "dev@dpdk.org" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 833461DB1 for ; Wed, 27 May 2015 16:40:00 +0200 (CEST) In-Reply-To: <55655D3D.8070208@netinsight.net> Content-Language: en-US Content-ID: <0F2579CDCE58954495B050775A4E6222@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/27/15, 12:59 AM, "Simon K=E5gstr=F6m" wrote: >Hi! > >As a well-meaning outsider submitting small patches to DPDK, I'd very >much appreciate help from the community with review and comments. Since >I'm a DPDK newbie, the patches might be incorrect or wrong in some other >way, so I think it's even more important with reviews for people like me. > >But I can't help getting this nagging feeling that the patches are >actually lost in the flood of mail to the DPDK mailing list, since I >haven't gotten any reaction to any of the three patches I've sent the >last month. > > >The patches in question are > > kni: Add set_rx_mode callback to handle multicast groups > rte_reorder: Allow sequence numbers > 0 as starting point > eal_common_options: Allow combining -m and --no-huge > >so if someone feels like mining their DPDK mail box, please review if >you have the time and knowledge about the area :-) > > >And I can't help thinking that maybe github pull requests would be >harder to miss (or at least easier to find after a few weeks of other >traffic). Do not open that can of worms :-) But I agree with you. > >// Simon