From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: [RFC PATCH] eal:Add new API for parsing args at
 rte_eal_init time
Date: Thu, 4 Jun 2015 11:50:33 +0000
Message-ID: <D195A551.21883%keith.wiles@intel.com>
References: <1433357393-54434-1-git-send-email-keith.wiles@intel.com>
 <20150603171255.545e0df8@urahara>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id AF4B6B3D6
 for <dev@dpdk.org>; Thu,  4 Jun 2015 13:50:47 +0200 (CEST)
In-Reply-To: <20150603171255.545e0df8@urahara>
Content-Language: en-US
Content-ID: <CBAEF4BB3E14E54A8CE3A873EF18C7C5@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Stephen

On 6/3/15, 7:12 PM, "Stephen Hemminger" <stephen@networkplumber.org> wrote:

>On Wed,  3 Jun 2015 13:49:53 -0500
>Keith Wiles <keith.wiles@intel.com> wrote:
>
>> +/* Launch threads, called at application init() and parse app args. */
>> +int
>> +rte_eal_init_parse(int argc, char **argv,
>> +		int (*parse)(int, char **))
>> +{
>> +	int	ret;
>> +
>> +	ret =3D rte_eal_init(argc, argv);
>> +	if ((ret >=3D 0) && (parse !=3D NULL)) {
>> +		argc -=3D ret;
>> +		argv +=3D ret;
>
>This won't work C is call by value.

I tested this routine with Pktgen (again), which has a number of
application options and it appears to work correctly. Can you explain why
this will not work?

Regards,
++Keith
>