From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: igb PMD should set the default tx wthresh correctly.
Date: Fri, 17 Jul 2015 11:06:00 +0000
Message-ID: <D1CE9FC2.24B0B%keith.wiles@intel.com>
References: <20150716101650.45c0e25a@urahara>
 <6A0DE07E22DDAD4C9103DF62FEBC0909CFAAE6@shsmsx102.ccr.corp.intel.com>
 <20150716194920.3710f25e@urahara> <1679490.KK3tNg9jEu@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, Stephen Hemminger
 <shemming@brocade.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id AFEF15A8C
 for <dev@dpdk.org>; Fri, 17 Jul 2015 13:06:03 +0200 (CEST)
In-Reply-To: <1679490.KK3tNg9jEu@xps13>
Content-Language: en-US
Content-ID: <428FDF0F8C23424FA0F979C9E1B4E281@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 7/17/15, 9:15 AM, "dev on behalf of Thomas Monjalon"
<dev-bounces@dpdk.org on behalf of thomas.monjalon@6wind.com> wrote:

>2015-07-16 19:49, Stephen Hemminger:
>> On Fri, 17 Jul 2015 00:52:09 +0000
>> "Lu, Wenzhuo" <wenzhuo.lu@intel.com> wrote:
>>=20
>> > Hi Stephen,
>> > I don't think there's a conflict. The message just reminder us that
>>we can adjust the values to achieve better performance.
>> > I saw ixgbe and i40e also use 0 as the same default value. To my
>>opinion, it's good to keep the same behavior.
>> > Thanks.
>>=20
>> In my opnion, no application should have to make special case setup
>> for each device type. Having to have a table that lists all the
>>parameters
>> for each device name is not supportable or scaleable.
>>=20
>> The DPDK started out as "lets do benchmarks fast" but as a production
>> toolkit it needs to stop having this kind of thing.
>>=20
>> The message shows up to the end-user, who thinks it is a driver bug.
>> The "us" is now real customers not DPDK developers.
>
>+1 to have better default values and less scary messages.
+1 I agree we should have default values. The scary message is for
debugging only in the best of cases and just wrong for the normal case.
>