From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sanford, Robert" Subject: Re: [PATCH] mbuf: fix tunnel flags check Date: Fri, 24 Jul 2015 15:06:25 +0000 Message-ID: References: <1437004212-31646-1-git-send-email-thomas.monjalon@6wind.com> <20150723084817.GG4924@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Adrien Mazarguil , Thomas Monjalon Return-path: Received: from prod-mail-xrelay02.akamai.com (prod-mail-xrelay02.akamai.com [72.246.2.14]) by dpdk.org (Postfix) with ESMTP id 073957EEF for ; Fri, 24 Jul 2015 17:06:28 +0200 (CEST) In-Reply-To: <20150723084817.GG4924@6wind.com> Content-Language: en-US Content-ID: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I just noticed a few minor typos in comments: diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 917dd59..6352c32 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -680,14 +680,14 @@ extern "C" { /** * Check if the (outer) L3 header is IPv4. To avoid comparing IPv4 types one by * one, bit 4 is selected to be used for IPv4 only. Then checking bit 4 can - * determin if it is an IPV4 packet. + * determine if it is an IPV4 packet. */ #define RTE_ETH_IS_IPV4_HDR(ptype) ((ptype) & RTE_PTYPE_L3_IPV4) =20 /** - * Check if the (outer) L3 header is IPv4. To avoid comparing IPv4 types one by - * one, bit 6 is selected to be used for IPv4 only. Then checking bit 6 can - * determin if it is an IPV4 packet. + * Check if the (outer) L3 header is IPv6. To avoid comparing IPv6 types one by + * one, bit 6 is selected to be used for IPv6 only. Then checking bit 6 can + * determine if it is an IPV6 packet. */ #define RTE_ETH_IS_IPV6_HDR(ptype) ((ptype) & RTE_PTYPE_L3_IPV6) -- Regards, Robert >On Thu, Jul 16, 2015 at 01:50:12AM +0200, Thomas Monjalon wrote: >> A packet is tunnelled if the tunnel type is identified or if it has >> an inner part. >>=20 >> Fix also a typo in RTE_PTYPE_INNER_L3_MASK. >>=20 >> Fixes: f295a00a2b44 ("mbuf: add definitions of unified packet types") >>=20 >> Signed-off-by: Thomas Monjalon > >Makes sense. > >Acked-by: Adrien Mazarguil > >--=20 >Adrien Mazarguil >6WIND