From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sujith Sankar (ssujith)" Subject: Re: [PATCH 1/2] enic: fix allocation when not using first numa node Date: Fri, 11 Sep 2015 08:28:19 +0000 Message-ID: References: <1441958551-29313-1-git-send-email-david.marchand@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "John Daley \(johndale\)" To: David Marchand , "dev@dpdk.org" Return-path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 068BF9E5 for ; Fri, 11 Sep 2015 10:28:21 +0200 (CEST) In-Reply-To: <1441958551-29313-1-git-send-email-david.marchand@6wind.com> Content-Language: en-US Content-ID: <1F0B46EE157E4A4EB9AA668B22500EB1@emea.cisco.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/09/15 1:32 pm, "David Marchand" wrote: >Seen by code review. > >If dpdk is run with memory only available on socket !=3D 0, then enic pmd >refuses to initialize ports as this pmd requires some memory on socket 0. >Fix this by setting socket to SOCKET_ID_ANY, so that allocations happen on >the caller socket. > >Signed-off-by: David Marchand >--- > drivers/net/enic/enic_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c >index 3b8719f..46a90bd 100644 >--- a/drivers/net/enic/enic_main.c >+++ b/drivers/net/enic/enic_main.c >@@ -539,7 +539,7 @@ enic_alloc_consistent(__rte_unused void *priv, size_t >size, > *dma_handle =3D 0; >=20 > rz =3D rte_memzone_reserve_aligned((const char *)name, >- size, 0, 0, ENIC_ALIGN); >+ size, SOCKET_ID_ANY, 0, ENIC_ALIGN); > if (!rz) { > pr_err("%s : Failed to allocate memory requested for %s", > __func__, name); >-- Acked by: Sujith Sankar >=20 >1.9.1 >