From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
Subject: Re: [PATCH 2/2] enic: fix hash creation when not using
 first numa node
Date: Fri, 11 Sep 2015 08:29:04 +0000
Message-ID: <D2188EC7.445DD%ssujith@cisco.com>
References: <1441958551-29313-1-git-send-email-david.marchand@6wind.com>
 <1441958551-29313-2-git-send-email-david.marchand@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "John Daley \(johndale\)" <johndale@cisco.com>
To: David Marchand <david.marchand@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75])
 by dpdk.org (Postfix) with ESMTP id A95F95934
 for <dev@dpdk.org>; Fri, 11 Sep 2015 10:29:06 +0200 (CEST)
In-Reply-To: <1441958551-29313-2-git-send-email-david.marchand@6wind.com>
Content-Language: en-US
Content-ID: <DB193DA313D94A46902556A7EA616A91@emea.cisco.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 11/09/15 1:32 pm, "David Marchand" <david.marchand@6wind.com> wrote:

>If dpdk is run with memory only available on socket !=3D 0, then hash
>creation will fail and flow director feature won't be available.
>Fix this by asking for allocation on caller socket.
>
>Signed-off-by: David Marchand <david.marchand@6wind.com>
>---
> drivers/net/enic/enic_clsf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
>index 656b25b..e7416ce 100644
>--- a/drivers/net/enic/enic_clsf.c
>+++ b/drivers/net/enic/enic_clsf.c
>@@ -61,7 +61,6 @@
> #define DEFAULT_HASH_FUNC       rte_jhash
> #endif
>=20
>-#define SOCKET_0                0
> #define ENICPMD_CLSF_HASH_ENTRIES       ENICPMD_FDIR_MAX
>=20
> void enic_fdir_stats_get(struct enic *enic, struct rte_eth_fdir_stats
>*stats)
>@@ -247,7 +246,7 @@ int enic_clsf_init(struct enic *enic)
> 		.key_len =3D sizeof(struct rte_eth_fdir_filter),
> 		.hash_func =3D DEFAULT_HASH_FUNC,
> 		.hash_func_init_val =3D 0,
>-		.socket_id =3D SOCKET_0,
>+		.socket_id =3D SOCKET_ID_ANY,
> 	};
>=20
> 	enic->fdir.hash =3D rte_hash_create(&hash_params);
>--

Acked by: Sujith Sankar <ssujith@cisco.com>


>=20
>1.9.1
>