From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Forster <alex@alexforster.com>
Subject: Re: Question about unsupported transceivers
Date: Thu, 15 Oct 2015 18:29:00 +0000
Message-ID: <D2456857.29A4%alex@alexforster.com>
References: <D2453FA3.2918%alex@alexforster.com> <561FD17E.6070908@gmail.com>
 <D2454A0C.2931%alex@alexforster.com> <561FE9A8.1010409@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Alexander Duyck <alexander.duyck@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from na01-by2-obe.outbound.protection.outlook.com
 (mail-by2on0100.outbound.protection.outlook.com [207.46.100.100])
 by dpdk.org (Postfix) with ESMTP id C3F095A53
 for <dev@dpdk.org>; Thu, 15 Oct 2015 20:29:03 +0200 (CEST)
In-Reply-To: <561FE9A8.1010409@gmail.com>
Content-Language: en-US
Content-ID: <7AE3458EE494DE48B6A41EE64DA61FE0@namprd06.prod.outlook.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/15/15, 2:00 PM, "Alexander Duyck" <alexander.duyck@gmail.com> wrote:

>
>Your changes are a bit over-kill and actually take things in the wrong
>direction.  By commenting out the whole allow_unsupported_sfp block you
>are disabling it by default.  Remember the module parameter allows it,
>by removing it there is no way to enable the feature.
>
>Like I mentioned in my previous email just take a look at replacing the
>"OPTION_DISABLED" value with "OPTION_ENABLED" in the .def part of the
>structure.  After that you won't need to pass the module parameter as it
>will always be enabled by default.
>
>- Alex

It's hard to see in the patch, but I basically replaced that whole option
check block with:

{
	/*
	* allow_unsupported_sfp - Enable/Disable support for unsupported
	* and untested SFP+ modules.
	*/
	adapter->hw.allow_unsupported_sfp =3D true;


}

Alex Forster