From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [PATCH v2 1/2] mbuf: add function returning default
 buffer address
Date: Thu, 10 Jan 2019 18:22:08 +0000
Message-ID: <D966BCB1-7F6F-4643-AFDE-4C93B6830CAC@mellanox.com>
References: <20190109085426.39965-1-yskoh@mellanox.com>
 <20190109131908.4949-1-yskoh@mellanox.com>
 <CAJFAV8ze4K90-snGs0Ddj7Ff6sejgd7KY-Zw=3wHST=gcqLOVw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Olivier Matz <olivier.matz@6wind.com>, Shahaf Shuler
 <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
To: David Marchand <david.marchand@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr00059.outbound.protection.outlook.com [40.107.0.59])
 by dpdk.org (Postfix) with ESMTP id 8FDF11B885
 for <dev@dpdk.org>; Thu, 10 Jan 2019 19:22:09 +0100 (CET)
In-Reply-To: <CAJFAV8ze4K90-snGs0Ddj7Ff6sejgd7KY-Zw=3wHST=gcqLOVw@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On Jan 9, 2019, at 5:46 AM, David Marchand <david.marchand@redhat.com<mailt=
o:david.marchand@redhat.com>> wrote:


On Wed, Jan 9, 2019 at 2:19 PM Yongseok Koh <yskoh@mellanox.com<mailto:ysko=
h@mellanox.com>> wrote:
This patch introduces two new functions - rte_mbuf_buf_addr_default() and
rte_mbuf_data_baddr_default().

rte_mbuf_buf_addr_default() reutrns the default buffer address of given
mbuf which comes after mbuf structure and private data.

The buffer address should always be the same for a given mbuf, there is no =
"default" value for it, there is only one value.
So for me s/rte_mbuf_buf_addr_default/rte_mbuf_buf_addr/g.

+1



rte_mbuf_data_baddr_default() returns the default address of mbuf data
taking the headroom into account.

Or just rte_mbuf_data_addr_default() ?

+1



Signed-off-by: Yongseok Koh <yskoh@mellanox.com<mailto:yskoh@mellanox.com>>

Those are new functions, they should go through the EXPERIMENTAL api markin=
g process.

If that's the rule, I'll follow anyway, although these are too obvious to b=
e experimental.

Thanks,
Yongseok