From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Roger Keith" Subject: [PATCH] rte_mempool_dump() crashes with NULL rte_mempool pointer. Date: Sat, 27 Sep 2014 18:35:01 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "" Return-path: Content-Language: en-US Content-ID: <9F346B39A9E4C44F8625649EA55EE177@local> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Check the FILE *f and rte_mempool *mp pointers for NULL and return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is enabled. Signed-off-by: Keith Wiles --- lib/librte_mempool/rte_mempool.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_memp= ool.c index 332f469..efa6a6c 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool.c @@ -765,6 +765,12 @@ rte_mempool_dump(FILE *f, const struct rte_mempool *mp= ) unsigned common_count; unsigned cache_count; + if ( (f =3D=3D NULL) || (mp =3D=3D NULL) ) { +#ifdef RTE_LIBRTE_MEMPOOL_DEBUG + fprintf(stderr, "*** Called rte_mempool_dump(%p, %p) with NULL argu= ment\n", f, mp); +#endif /* RTE_LIBRTE_MEMPOOL_DEBUG */ + return; + } fprintf(f, "mempool <%s>@%p\n", mp->name, mp); fprintf(f, " flags=3D%x\n", mp->flags); fprintf(f, " ring=3D<%s>@%p\n", mp->ring->name, mp->ring); --=20 2.1.0