From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shahaf Shuler Subject: Re: [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check Date: Wed, 14 Nov 2018 14:56:00 +0000 Message-ID: References: <1541225876-8817-2-git-send-email-viacheslavo@mellanox.com> <1542052877-41512-1-git-send-email-viacheslavo@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Shahaf Shuler , Slava Ovsiienko , Yongseok Koh Return-path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00056.outbound.protection.outlook.com [40.107.0.56]) by dpdk.org (Postfix) with ESMTP id BED1E1B11C for ; Wed, 14 Nov 2018 15:56:01 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tuesday, November 13, 2018 3:21 PM, Shahaf Shuler: > Subject: Re: [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rul= e > flags check >=20 > Monday, November 12, 2018 10:02 PM, Slava Ovsiienko: > > Subject: [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags > > check > > > > The tc flower filter rules are used to control E-switch from the > > application side. In order to gain garanteed rule hardware offload the > > skip_sw flag should be specified while applying the rule. Some tc > > rules is rejected by kernel if skip_sw flag is set by design. > > Currently this regards VXLAN tunneling rules only, which are applied to > special VXLAN virtual devices. > > > > Albeit these rules should be applied with no skip_sw flag set the > > kernel tries to perform hardware offload. If kernel succeeded the > > in_hw flag is set in rule properties and application may check this > > flag to get know whether the applied rule is actually hardware offloade= d. > > > > Signed-off-by: Viacheslav Ovsiienko > > >=20 > Hi Slava, > In general looks good. Please see few comments. >=20 > In addition, please make the signed-of name and the author name match for > the next version. Series applied to next-net-mlx, with modification of the author name. Thank= s.