* [PATCH] net/tap: avoid using netlink socket if closed
@ 2026-04-03 19:26 Stephen Hemminger
2026-04-05 18:23 ` Robin Jarry
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2026-04-03 19:26 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, stable, Robin Jarry
Coverity flagged that nlsk_fd could be negative when passed
to tap_nl_set_flags() during device close.
Coverity issue: 502576
Fixes: b5d76639551e ("net/tap: replace ioctl with Netlink")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/tap/rte_eth_tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index a5d460a0b3..ba9aef74c0 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1124,7 +1124,7 @@ tap_dev_close(struct rte_eth_dev *dev)
}
}
- if (internals->remote_if_index) {
+ if (internals->remote_if_index != 0 && internals->nlsk_fd != -1) {
/* Restore initial remote state */
int ret = tap_nl_set_flags(internals->nlsk_fd, internals->remote_if_index,
internals->remote_initial_flags, 1);
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/tap: avoid using netlink socket if closed
2026-04-03 19:26 [PATCH] net/tap: avoid using netlink socket if closed Stephen Hemminger
@ 2026-04-05 18:23 ` Robin Jarry
0 siblings, 0 replies; 2+ messages in thread
From: Robin Jarry @ 2026-04-05 18:23 UTC (permalink / raw)
To: Stephen Hemminger, dev; +Cc: stable
Stephen Hemminger, Apr 03, 2026 at 21:26:
> Coverity flagged that nlsk_fd could be negative when passed
> to tap_nl_set_flags() during device close.
>
> Coverity issue: 502576
> Fixes: b5d76639551e ("net/tap: replace ioctl with Netlink")
> Cc: stable@dpdk.org
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Thanks for the fix Stephen.
Reviewed-by: Robin Jarry <rjarry@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-05 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-03 19:26 [PATCH] net/tap: avoid using netlink socket if closed Stephen Hemminger
2026-04-05 18:23 ` Robin Jarry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox