DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Robin Jarry" <rjarry@redhat.com>
To: "David Marchand" <david.marchand@redhat.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, "Aaron Conole" <aconole@redhat.com>,
	"Bruce Richardson" <bruce.richardson@intel.com>
Subject: Re: [PATCH] ci: fix dependency on cmdline
Date: Thu, 15 Oct 2026 18:23:30 +0200	[thread overview]
Message-ID: <DM5JUAJZOBD1.1MJUHEI3YCXCO@redhat.com> (raw)
In-Reply-To: <20261015160157.3348253-1-david.marchand@redhat.com>

David Marchand, Oct 15, 2026 at 18:01:
> The unit tests, testpmd and some examples depend on the cmdline library.
> Without it, the "mini" target in GHA ends up as a build failure.
>
> Fixes: 6de2c9c791b8 ("build: make cmdline optional")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  .ci/linux-build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> index 4f266940e9..2c7386d320 100755
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> @@ -120,7 +120,7 @@ else
>  fi
>  if [ "$MINI" = "true" ]; then
>      OPTS="$OPTS -Denable_drivers=net/null"
> -    OPTS="$OPTS -Ddisable_libs=*"
> +    OPTS="$OPTS -Denable_libs=cmdline"
>      if [ "$DEF_LIB" = "static" ]; then
>          OPTS="$OPTS -Dexamples=l2fwd"

Why aren't the per-target dependencies honored?

-- 
Robin

# At participating locations only.


  parent reply	other threads:[~2026-10-15 16:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 16:01 [PATCH] ci: fix dependency on cmdline David Marchand
2026-10-15 16:18 ` David Marchand
2026-10-15 16:23 ` Robin Jarry [this message]
2026-10-15 16:25   ` David Marchand
2026-10-15 16:26     ` Robin Jarry
2026-10-15 16:31       ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5JUAJZOBD1.1MJUHEI3YCXCO@redhat.com \
    --to=rjarry@redhat.com \
    --cc=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox