From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH v2 01/12] lib/rte_security: add security library Date: Thu, 5 Oct 2017 15:32:59 +0000 Message-ID: References: <20170914082651.26232-1-akhil.goyal@nxp.com> <20171003131413.23846-1-akhil.goyal@nxp.com> <20171003131413.23846-2-akhil.goyal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Doherty, Declan" , "hemant.agrawal@nxp.com" , "Nicolau, Radu" , "borisp@mellanox.com" , "aviadye@mellanox.com" , "thomas@monjalon.net" , "sandeep.malik@nxp.com" , "jerin.jacob@caviumnetworks.com" , "Mcnamara, John" , "olivier.matz@6wind.com" To: Akhil Goyal , "dev@dpdk.org" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 209931B208 for ; Thu, 5 Oct 2017 17:33:04 +0200 (CEST) In-Reply-To: <20171003131413.23846-2-akhil.goyal@nxp.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Tuesday, October 3, 2017 2:14 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agrawal@nxp.com; Nicolau, > Radu ; borisp@mellanox.com; > aviadye@mellanox.com; thomas@monjalon.net; sandeep.malik@nxp.com; > jerin.jacob@caviumnetworks.com; Mcnamara, John > ; olivier.matz@6wind.com > Subject: [PATCH v2 01/12] lib/rte_security: add security library >=20 > rte_security library provides APIs for security session create/free for > protocol offload or offloaded crypto operation to ethernet device. >=20 > Signed-off-by: Akhil Goyal > Signed-off-by: Boris Pismenny > Signed-off-by: Radu Nicolau > Signed-off-by: Declan Doherty ... > +} > diff --git a/lib/librte_security/rte_security.h > b/lib/librte_security/rte_security.h ... When building the docs with "make-guides-html", It is complaining about an item in this list: lib/librte_security/rte_security.h:139: warning: Invalid list item found > +/** > + * IPsec Security Association option flags */ struct > +rte_security_ipsec_sa_options { > + /**< Extended Sequence Numbers (ESN) > + * > + * * 1: Use extended (64 bit) sequence numbers > + * * 0: Use normal sequence numbers > + */ > + uint32_t esn : 1; > + > + /**< UDP encapsulation > + * > + * * 1: Do UDP encapsulation/decapsulation so that IPSEC packets > can > + * traverse through NAT boxes. > + * * 0: No UDP encapsulation > + */ > + uint32_t udp_encap : 1; ... > +/** > + * Updates the buffer with device-specific defined metadata > + * > + * @param id security instance identifier id > + * @param sess security session > + * @param m packet mbuf to set metadata on. Parameter is called "mb". > + * @param params device-specific defined parameters required for > metadata > + * > + * @return > + * - On success, zero. > + * - On failure, a negative value. > + */ > +int > +rte_security_set_pkt_metadata(uint16_t id, > + struct rte_security_session *sess, > + struct rte_mbuf *mb, void *params);