From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH v4 09/18] net/qede: strncpy length constant and NUL Date: Fri, 11 May 2018 15:14:30 +0000 Message-ID: References: <152600304856.53146.9681482138854493833.stgit@localhost.localdomain> <152600316103.53146.10955338688055072616.stgit@localhost.localdomain> <1a5248e0-d33f-db7c-748e-39805a111aa2@warmcat.com> <7462e3b8-d0ec-a90f-0fa8-bae565ce6634@warmcat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "stable@dpdk.org" , "Mody, Rasesh" , "Patil, Harish" , "Shahed.Shaikh@cavium.com" To: Andy Green , "dev@dpdk.org" Return-path: In-Reply-To: <7462e3b8-d0ec-a90f-0fa8-bae565ce6634@warmcat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQW5keSBHcmVlbiBbbWFp bHRvOmFuZHlAd2FybWNhdC5jb21dDQo+IFNlbnQ6IEZyaWRheSwgTWF5IDExLCAyMDE4IDI6Mzkg UE0NCj4gVG86IERlIExhcmEgR3VhcmNoLCBQYWJsbyA8cGFibG8uZGUubGFyYS5ndWFyY2hAaW50 ZWwuY29tPjsgZGV2QGRwZGsub3JnDQo+IENjOiBzdGFibGVAZHBkay5vcmc7IE1vZHksIFJhc2Vz aCA8UmFzZXNoLk1vZHlAY2F2aXVtLmNvbT47IFBhdGlsLCBIYXJpc2gNCj4gPEhhcmlzaC5QYXRp bEBjYXZpdW0uY29tPjsgU2hhaGVkLlNoYWlraEBjYXZpdW0uY29tDQo+IFN1YmplY3Q6IFJlOiBb ZHBkay1kZXZdIFtQQVRDSCB2NCAwOS8xOF0gbmV0L3FlZGU6IHN0cm5jcHkgbGVuZ3RoIGNvbnN0 YW50IGFuZA0KPiBOVUwNCj4gDQo+IA0KPiANCj4gT24gMDUvMTEvMjAxOCAwODo0OCBQTSwgRGUg TGFyYSBHdWFyY2gsIFBhYmxvIHdyb3RlOg0KPiA+DQo+ID4NCj4gPj4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogQW5keSBHcmVlbiBbbWFpbHRvOmFuZHlAd2FybWNhdC5j b21dDQo+ID4+IFNlbnQ6IEZyaWRheSwgTWF5IDExLCAyMDE4IDExOjQ4IEFNDQo+ID4+IFRvOiBE ZSBMYXJhIEd1YXJjaCwgUGFibG8gPHBhYmxvLmRlLmxhcmEuZ3VhcmNoQGludGVsLmNvbT47DQo+ ID4+IGRldkBkcGRrLm9yZw0KPiA+PiBDYzogc3RhYmxlQGRwZGsub3JnOyBNb2R5LCBSYXNlc2gg PFJhc2VzaC5Nb2R5QGNhdml1bS5jb20+OyBQYXRpbCwNCj4gPj4gSGFyaXNoIDxIYXJpc2guUGF0 aWxAY2F2aXVtLmNvbT47IFNoYWhlZC5TaGFpa2hAY2F2aXVtLmNvbQ0KPiA+PiBTdWJqZWN0OiBS ZTogW2RwZGstZGV2XSBbUEFUQ0ggdjQgMDkvMThdIG5ldC9xZWRlOiBzdHJuY3B5IGxlbmd0aA0K PiA+PiBjb25zdGFudCBhbmQgTlVMDQo+ID4+DQo+ID4+DQo+ID4+DQo+ID4+IE9uIDA1LzExLzIw MTggMDY6NDMgUE0sIERlIExhcmEgR3VhcmNoLCBQYWJsbyB3cm90ZToNCj4gPj4+DQo+ID4+Pg0K PiA+Pj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+Pj4gRnJvbTogZGV2IFttYWls dG86ZGV2LWJvdW5jZXNAZHBkay5vcmddIE9uIEJlaGFsZiBPZiBBbmR5IEdyZWVuDQo+ID4+Pj4g U2VudDogRnJpZGF5LCBNYXkgMTEsIDIwMTggMjo0NiBBTQ0KPiA+Pj4+IFRvOiBkZXZAZHBkay5v cmcNCj4gPj4+PiBTdWJqZWN0OiBbZHBkay1kZXZdIFtQQVRDSCB2NCAwOS8xOF0gbmV0L3FlZGU6 IHN0cm5jcHkgbGVuZ3RoDQo+ID4+Pj4gY29uc3RhbnQgYW5kIE5VTA0KPiA+Pj4+DQo+ID4+Pj4g U2lnbmVkLW9mZi1ieTogQW5keSBHcmVlbiA8YW5keUB3YXJtY2F0LmNvbT4NCj4gPj4+PiAtLS0N Cj4gPj4+PiAgICBkcml2ZXJzL25ldC9xZWRlL2Jhc2UvZWNvcmVfaW50LmMgfCAgICA4ICsrKysr LS0tDQo+ID4+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlv bnMoLSkNCj4gPj4+Pg0KPiA+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9xZWRlL2Jhc2Uv ZWNvcmVfaW50LmMNCj4gPj4+PiBiL2RyaXZlcnMvbmV0L3FlZGUvYmFzZS9lY29yZV9pbnQuYw0K PiA+Pj4+IGluZGV4IGY0Mzc4MWJhNC4uZDllMjJiNWVkIDEwMDY0NA0KPiA+Pj4+IC0tLSBhL2Ry aXZlcnMvbmV0L3FlZGUvYmFzZS9lY29yZV9pbnQuYw0KPiA+Pj4+ICsrKyBiL2RyaXZlcnMvbmV0 L3FlZGUvYmFzZS9lY29yZV9pbnQuYw0KPiA+Pj4+IEBAIC02LDYgKzYsOCBAQA0KPiA+Pj4+ICAg ICAqIFNlZSBMSUNFTlNFLnFlZGVfcG1kIGZvciBjb3B5cmlnaHQgYW5kIGxpY2Vuc2luZyBkZXRh aWxzLg0KPiA+Pj4+ICAgICAqLw0KPiA+Pj4+DQo+ID4+Pj4gKyNpbmNsdWRlIDxydGVfc3RyaW5n X2Zucy5oPg0KPiA+Pj4+ICsNCj4gPj4+PiAgICAjaW5jbHVkZSAiYmNtX29zYWwuaCINCj4gPj4+ PiAgICAjaW5jbHVkZSAiZWNvcmUuaCINCj4gPj4+PiAgICAjaW5jbHVkZSAiZWNvcmVfc3BxLmgi DQo+ID4+Pj4gQEAgLTExMDQsOSArMTEwNiw5IEBAIHN0YXRpYyBlbnVtIF9lY29yZV9zdGF0dXNf dA0KPiA+Pj4+IGVjb3JlX2ludF9kZWFzc2VydGlvbihzdHJ1Y3QgZWNvcmVfaHdmbiAqcF9od2Zu LA0KPiA+Pj4+ICAgIAkJCQkJCQkgICAgICBwX2FldS0+Yml0X25hbWUsDQo+ID4+Pj4gICAgCQkJ CQkJCSAgICAgIG51bSk7DQo+ID4+Pj4gICAgCQkJCQllbHNlDQo+ID4+Pj4gLQkJCQkJCU9TQUxf U1RSTkNQWShiaXRfbmFtZSwNCj4gPj4+PiAtCQkJCQkJCSAgICAgcF9hZXUtPmJpdF9uYW1lLA0K PiA+Pj4+IC0JCQkJCQkJICAgICAzMCk7DQo+ID4+Pj4gKwkJCQkJCXN0cmxjcHkoYml0X25hbWUs DQo+ID4+Pj4gKwkJCQkJCQlwX2FldS0+Yml0X25hbWUsDQo+ID4+Pj4gKwkJCQkJCQlzaXplb2Yo Yml0X25hbWUpKTsNCj4gPj4+Pg0KPiA+Pj4+ICAgIAkJCQkJLyogV2Ugbm93IG5lZWQgdG8gcGFz cyBiaXRtYXNrIGluIGl0cw0KPiA+Pj4+ICAgIAkJCQkJICogY29ycmVjdCBwb3NpdGlvbi4NCj4g Pj4+DQo+ID4+PiBJJ2Qgc2F5IGl0IHNob3VsZCBiZSBiZXR0ZXIgdG8gY2hhbmdlIE9TQUxfU1RS TkNQWSB0byBPU0FMX1NUUkxDUFkNCj4gPj4+IGFuZCBtb2RpZnkgdGhlIG1hY3JvIHRvIHVzZSBz dHJsY3B5LCBzbyB3ZSBhdm9pZCBmdXJ0aGVyIHVzZXMgb2YgdGhhdA0KPiBzdHJsY3B5Lg0KPiA+ Pj4NCj4gPj4+IEhvd2V2ZXIsIHRoaXMgbW9kaWZpZXMgYmFzZSBkcml2ZXIgY29kZSwgc28gaXQg aXMgdXAgdG8gdGhlDQo+ID4+PiBtYWludGFpbmVycyB0byBtYWtlDQo+ID4+IHRoYXQgZGVjaXNp b24uDQo+ID4+PiAoQ0MnaW5nIG1haW50YWluZXJzIGhlcmUpLg0KPiA+Pg0KPiA+PiBUaGVyZSdz IG5vIHZhbHVlIGZvciBhbnkgT1NBTF8qIHRoYXQgc2ltcGx5IGRlZmluZXMgaXRzZWxmIHRvIGJl IHRoZQ0KPiA+PiBzYW1lIGFzIHRoZSBkaXJlY3QgYXBpLCBhcyBkb2VzIE9TQUxfU1RSTkNQWS4N Cj4gPj4NCj4gPj4gSXQncyBiZXR0ZXIgdG8ganVzdCByZW1vdmUgYW55IE9TQUxfKiB0aGF0IGNh bGxzIHN0cmFpZ2h0IHRocm91Z2gNCj4gPj4gc2luY2UgYWxsIGl0IGRvZXMgaXMgb2JmdXNjYXRl IHdoYXQgdGhlIGNvZGUgZG9lcywgZm9yIG5vIGJlbmVmaXQuDQo+ID4NCj4gPiBJIGFncmVlLiBT aW5jZSB0aGlzIGlzIG1vZGlmeWluZyBiYXNlIGRyaXZlciBjb2RlLCB0aGUgbWFpbnRhaW5lcnMg Y2FuDQo+ID4gZGVjaWRlIHdoYXQgdG8gZG8gd2l0aCB0aGlzLg0KPiA+DQo+ID4+DQo+ID4+PiBB bHNvLCBtaXNzaW5nIGZpeGVzIGxpbmUgYW5kIENDIHN0YWJsZS4NCj4gPj4+DQo+ID4+PiBGaXhl czogODQyN2M2NjQ3OTY0ICgibmV0L3FlZGUvYmFzZTogYWRkIGF0dGVudGlvbiBmb3JtYXR0aW5n DQo+ID4+PiBzdHJpbmciKQ0KPiA+Pg0KPiA+PiBUaGUgaWRlYSBvZiB0aGlzICJGaXhlcyIgdGhp bmcgaXMgdG8gbG9vayB1cCBpbiBnaXQgYmxhbWUgd2hhdCBpcyBiZWluZyBlZGl0ZWQgaXMNCj4g aXQ/DQo+ID4+IElmIHNvIHdoYXQncyB0aGUgYmVuZWZpdCBvZiB0aGF0IG92ZXIgdXNpbmcgZ2l0 IGlmIHlvdSBldmVyIHdhbnQgdG8ga25vdyB0aGF0Pw0KPiA+Pg0KPiA+DQo+ID4gVGhpcyBpcyBp bXBvcnRhbnQgbWFpbmx5IHRvIHNlZSB3aGljaCByZWxlYXNlcyBuZWVkZWQgdGhpcyBwYXRjaCBi YWNrcG9ydGVkLg0KPiA+IEkgYW0gcmVwbHlpbmcgdG8geW91ciBwYXRjaGVzIHdpdGggdGhpcyBp bmZvLCB0byBzYXZlIHlvdSBzb21lIHRpbWUgKEkNCj4gPiBrbm93IHlvdSBhcmUgZmVlbGluZyB0 aGUgcGFpbiBvZiB0aGlzIG92ZXJoZWFkIDpQKS4NCj4gDQo+IFllYWg6IEkgYXBwcmVjaWF0ZSB0 aGUgaGVscC4gIFNvbWUgb2YgdGhlIGN1cnJlbnQgcnVsZXMgbWFrZSBhc3N1bXB0aW9ucyBhYm91 dA0KPiBidXJuaW5nIHRpbWUgZm9yIG5vIHJlYWwgYmVuZWZpdCB0aGF0IGFzc3VtZSB0aGUgY29u dHJpYnV0b3IgaGFzIG5vIGNob2ljZSBidXQNCj4gdG8gY29tcGx5LiAgQnV0IHRoYXQgaXMgc2lt cGx5IG5vdCB0cnVlIGZvciBhbGwgcG90ZW50aWFsIGNvbnRyaWJ1dG9ycy4NCj4gDQo+IEkgd2ls bCBpbnRlZ3JhdGUgdGhlIGNvbW1lbnRzIHRvbW9ycm93IG1vcm5pbmcgKGllLCArMTJoKSBhbmQg cHVzaCBhZ2Fpbi4gIEkNCj4gd2lsbCBsb29rIGNsb3NlciBhdCB0aGUgbWlzc2luZyBpbmNsdWRl IHRoaW5nLCBidXQgc2luY2UgYnVpbGQgc3RvcHMsIHRlbGxpbmcgbWUgaXQNCj4gY2FuJ3QgZmlu ZCB0aGUgaW5jbHVkZSBmaWxlLCBhbmQgdGhlIHBhdGNoIGZpeGVzIGl0LCB0aGVyZSBhcmUgYSBs aW1pdGVkIGFtb3VudCBvZg0KPiBwb3NzaWJsZSByb290IGNhdXNlcy4NCg0KVGhhbmtzIGZvciB5 b3VyIHRpbWUsIEFuZHkuDQoNClBhYmxvDQo=