From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Richardson, Bruce" Subject: Re: Testpmd returns error. Date: Sun, 22 Feb 2015 18:51:58 +0000 Message-ID: References: <54E9695A.5010509@igel.co.jp> <3376494.YE1J4OXSVA@xps13>, Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: David Marchand Return-path: In-Reply-To: Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 22 Feb 2015, at 16:19, David Marchand > wrote: Hello, On Sun, Feb 22, 2015 at 3:17 PM, Thomas Monjalon > wrote: Hi Tetsuya, > Someone, could you please check it? It is possible that this patchset was not correctly tested. We might revert it or try to fix it. I think the decision should be done by its authors (Danny, Bruce), or the Linux EAL maintainer (David). Well, I need to have a deeper look at this change. I did not find time before my holidays. - I think there may be an issue with the use of resource0 instead of /dev/u= io. I am not sure uio mmap will be happy or I overlooked something trivial. - Testing proc type in pci_uio_map_resource() looks wrong to me, since we v= alidated earlier in this same function that we are in primary process. - uio_res->maps indexes are not the same as the pci resources, might trigge= r problems (and it clearly does not make it easy to read ...). And now we are reading sysfs twice. I would prefer this code is reworked so that we avoid those loops in eal_pc= i_uio.c. Anyway, I am still on holiday (I should have kept my laptop away ...), I wi= ll be back tomorrow. I suppose Bruce or Danny will come with a fix, let's decide what the best s= olution is at this moment. I'll take another look at this but unfortunately I don't think I can necess= arily reproduce this issue as it seems to occur with enic driver, but I wil= l try. -- David Marchand