From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: [PATCH 01/19] devtools: add simple script to find duplicate includes Date: Fri, 14 Jul 2017 16:17:45 +0000 Message-ID: References: <20170711185546.26138-1-stephen@networkplumber.org> <7177425.p9cP4Rfg1a@xps> <12511927.qublii9NrP@xps> <62513523.FtO1afHum7@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Stephen Hemminger , "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 248055699 for ; Fri, 14 Jul 2017 18:17:46 +0200 (CEST) In-Reply-To: <62513523.FtO1afHum7@xps> Content-Language: en-US Content-ID: <9A74FA0082C21E4BAFBADA1F8D49CA29@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Jul 14, 2017, at 10:54 AM, Thomas Monjalon wrote= : >=20 > 14/07/2017 17:39, Thomas Monjalon: >> 13/07/2017 08:56, Thomas Monjalon: >>> 12/07/2017 23:59, Stephen Hemminger: >>>> On Tue, 11 Jul 2017 22:33:55 +0200 >>>> Thomas Monjalon wrote: >>>>=20 >>>>> Thank you for this script, but... it is written in Perl! >>>>> I don't think it is a good idea to add yet another language to DPDK. >>>>> We already have shell and python scripts. >>>>> And I am not sure a lot of (young) people are able to parse it ;) >>>>>=20 >>>>> I would like to propose this shell script: >> [...] >>>=20 >>>> plus shell is 7x slower. >>>>=20 >>>> $ time bash -c "find . -name '*.c' | xargs /tmp/dupinc.sh" >>>> real 0m0.765s >>>> user 0m1.220s >>>> sys 0m0.155s >>>> $time bash -c "find . -name '*.c' | xargs ~/bin/dup_inc.pl" >>>> real 0m0.131s >>>> user 0m0.118s >>>> sys 0m0.014s >>>=20 >>> I don't think speed is really relevant here :) >>=20 >> I did my own benchmark (recreation time): >>=20 >> # time sh -c 'for file in $(git ls-files app buildtools drivers examples= lib test) ; do devtools/dup_include.pl $file ; done' >> 4,41s user 1,32s system 101% cpu 5,667 total >> # time devtools/check-duplicate-includes.sh >> 5,48s user 1,00s system 153% cpu 4,222 total >>=20 >> The shell version is reported as faster on my computer! >>=20 >> It is faster when filtering only .c and .h files: >>=20 >> for file in $(git ls-files '*.[ch]') ; do >> dups=3D$(sed -rn "s,$pattern,\1,p" $file | sort | uniq -d) >> [ -z "$dups" ] || echo "$dups" | sed "s,^,$file: duplicated include: = ," >> done >>=20 >> # time sh -c 'for file in $(git ls-files "*.[ch]") ; do devtools/dup_inc= lude.pl $file ; done' >> 3,65s user 1,05s system 100% cpu 4,668 total >> # time devtools/check-duplicate-includes.sh >> 4,72s user 0,80s system 153% cpu 3,603 total >>=20 >> I prefer this version using only pipes, which is well parallelized: >>=20 >> for file in $(git ls-files '*.[ch]') ; do >> sed -rn "s,$pattern,\1,p" $file | sort | uniq -d | >> sed "s,^,$file: duplicated include: ," >> done >>=20 >> 7,40s user 1,49s system 231% cpu 3,847 total >=20 > And now, the big shell optimization: > export LC_ALL=3DC > Result is impressive: > 2,99s user 0,72s system 258% cpu 1,436 total >=20 > I'm sure you will agree to integrate my version now :) >=20 hands down winner, where is the patch? :-) >=20 Regards, Keith