From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: [RFC 2/2] prgdev: introduce generic prgdev API Date: Wed, 8 Feb 2017 23:06:51 +0000 Message-ID: References: <1484882498-18653-1-git-send-email-jing.d.chen@intel.com> <1484882498-18653-3-git-send-email-jing.d.chen@intel.com> <20170208144945.0ce116ee@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Chen, Jing D" , "dev@dpdk.org" , "Rogers, Gerald" To: Stephen Hemminger Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 77C929E7 for ; Thu, 9 Feb 2017 00:06:54 +0100 (CET) In-Reply-To: <20170208144945.0ce116ee@xeon-e3> Content-Language: en-US Content-ID: <5CCFBFB4CA95834DB52B382646B7C4B3@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Feb 8, 2017, at 4:49 PM, Stephen Hemminger wrote: >=20 > On Fri, 20 Jan 2017 11:21:38 +0800 > "Chen Jing D(Mark)" wrote: >=20 >> +struct rte_prg_dev_info { >> + struct rte_pci_device *pci_dev; /**< Device PCI information. */ >=20 > NAK >=20 > No new API should refer to PCI devices. We are trying to make all referen= ces > to devices generic. Crypto suceeded, ether is in process, but no new ones= please. The design is not PCI centric and should not be PCI centric, it is just wha= t they started with months ago. So please look past the PCI bits as they ha= ve not integrated into the latest code base yet. Regards, Keith