From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tan, Jianfeng" Subject: Re: [PATCH] virtio: fix used ring address calculation Date: Mon, 21 Sep 2015 09:19:19 +0000 Message-ID: References: <1442806742-32547-1-git-send-email-huawei.xie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "Xie, Huawei" , "dev@dpdk.org" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 71BCCCE7 for ; Mon, 21 Sep 2015 11:19:31 +0200 (CEST) In-Reply-To: <1442806742-32547-1-git-send-email-huawei.xie@intel.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Huawei Xie Sent: Monday, September 21, 2015 11:39 AM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH] virtio: fix used ring address calculation used event idx is put at the end of available ring. It isn't taken into acc= ount when we calculate the address of used ring. Fortunately, it doesn't in= troduce the bug with fixed queue number 256 and 4KB alignment. Signed-off-by: hxie5 --- drivers/net/virtio/virtio_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_r= ing.h index a16c499..92e430d 100644 --- a/drivers/net/virtio/virtio_ring.h +++ b/drivers/net/virtio/virtio_ring.h @@ -145,7 +145,7 @@ vring_init(struct vring *vr, unsigned int num, uint8_t = *p, vr->avail =3D (struct vring_avail *) (p + num * sizeof(struct vring_desc)); vr->used =3D (void *) - RTE_ALIGN_CEIL((uintptr_t)(&vr->avail->ring[num]), align); + RTE_ALIGN_CEIL((uintptr_t)(&vr->avail->ring[num + 1]), align); } =20 /* -- Acked-by: Jianfeng Tan 1.9.3