From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andriy Berestovskyy Subject: Re: [PATCH v3] ether: use a default for max Rx frame size in configure() Date: Thu, 24 May 2018 11:20:18 +0200 Message-ID: References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com> <1719643.qo6JmGv4pL@xps> <7564896.sbN2ypR4X7@xps> Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Cc: Thomas Monjalon , "dev@dpdk.org" , Bruce Richardson , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "hemant.agrawal@nxp.com" , "jerin.jacob@cavium.com" To: Shahaf Shuler Return-path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id A92DD2C8 for ; Thu, 24 May 2018 11:20:20 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id n10-v6so3157204wmc.1 for ; Thu, 24 May 2018 02:20:20 -0700 (PDT) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Shahaf, > On 23 May 2018, at 07:21, Shahaf Shuler wrote: > I think this patch addressing just small issue in a bigger problem. > The way I see it all application needs to specify is the max packet = size it expects to receive, nothing else(!).=20 [...] > IMO The "jumbo_frame" bit can be set by the underlying PMD directly to = the device registers given the max_rx_pkt_len configuration.=20 Sure, it can be deducted in PMD if max_rx_pkt_len is greater than the = normal frame size. The background behind this patch was to fix some examples on some = platforms by allowing them to just set the jumbo bit in config and let = the DPDK to deduct the optimal jumbo max_rx_pkt_len. There was also another patch which fixed those examples, so they first = query the max_rx_pkt_len and then pass it with the config: http://dpdk.org/commit/5e470a6654 That patch has been merged, so now we can fix/change the API in any way = we decide, there is no urgency anymore. Looks like the jumbo bit in config is redundant, but there might be = other opinions. Andriy