From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eelco Chaudron" Subject: Re: [PATCH 3/3] lib/librte_meter: update abi to include new rfc4115 function Date: Wed, 28 Nov 2018 10:27:04 +0100 Message-ID: References: <154333204294.44971.12989297399338053044.stgit@dbuild> <154333210155.44971.11196185167374567770.stgit@dbuild> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: cristian.dumitrescu@intel.com, dev@dpdk.org To: "David Marchand" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 11AA11B3DA for ; Wed, 28 Nov 2018 10:27:11 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 28 Nov 2018, at 9:38, David Marchand wrote: > Hello Eelco, > > On Tue, Nov 27, 2018 at 4:22 PM Eelco Chaudron > wrote: > >> Update the ABI to include the new RFC4115 meter functions >> --- >> lib/librte_meter/Makefile | 2 +- >> lib/librte_meter/meson.build | 2 +- >> lib/librte_meter/rte_meter_version.map | 9 +++++++++ >> 3 files changed, 11 insertions(+), 2 deletions(-) >> >> diff --git a/lib/librte_meter/Makefile b/lib/librte_meter/Makefile >> index 2dc071e8e..79ad79744 100644 >> --- a/lib/librte_meter/Makefile >> +++ b/lib/librte_meter/Makefile >> @@ -16,7 +16,7 @@ LDLIBS += -lrte_eal >> >> EXPORT_MAP := rte_meter_version.map >> >> -LIBABIVER := 2 >> +LIBABIVER := 3 >> >> # >> # all source are stored in SRCS-y >> > > As far as I understood the policy around the EXPERIMENTAL section, you > don't need to bump the library version. Thought I would add the new function as none experimental, i.e. next version, but checkpatch did not allow me to do this. Tried to find info on what the right process was, as these functions are just another meter implementation using similar existing APIs. If anyone has any background on this please point me to it. I changed the library version as an existing data structure changed (which in theory should not change the location of the data), but the ABI check popped warnings so I decided to increase the version. > > + you should squash this into the first patch. I’ll do this on the next version. Thanks, Eelco