From: Thomas Monjalon <thomas@monjalon.net>
To: Shani Peretz <shperetz@nvidia.com>, Maayan Kashani <mkashani@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org, rasland@nvidia.com,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>
Subject: Re: [PATCH] app/testpmd: fix flow cfg double-free after reattach
Date: Fri, 10 Jul 2026 23:45:12 +0200 [thread overview]
Message-ID: <EJr8j25HT4mwZawFv5CL1g@monjalon.net> (raw)
In-Reply-To: <20260706115248.188551-1-mkashani@nvidia.com>
06/07/2026 13:52, Maayan Kashani:
> From: Shani Peretz <shperetz@nvidia.com>
>
> When a port is closed via close_port(), port_free_job_list() frees the
> job_list but does not NULL the pointer or reset queue_nb. If the port
> is later reattached and "flow configure" is issued, port_flow_configure()
> frees the dangling job_list pointer, causing a double-free.
>
> Fix this by setting job_list to NULL and resetting queue_nb to zero in
> port_free_job_list() after freeing.
>
> Fixes: 7fadc8039588 ("app/testpmd: fix memory leak in port flow configure")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shani Peretz <shperetz@nvidia.com>
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Applied, thanks.
prev parent reply other threads:[~2026-07-10 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 11:52 [PATCH] app/testpmd: fix flow cfg double-free after reattach Maayan Kashani
2026-07-10 21:45 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EJr8j25HT4mwZawFv5CL1g@monjalon.net \
--to=thomas@monjalon.net \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=rasland@nvidia.com \
--cc=shperetz@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox