From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yang, Qiming" <qiming.yang@intel.com>
Subject: Re: [PATCH] igb_uio: remove PCI reset during uio device
	open
Date: Fri, 22 Sep 2017 02:47:35 +0000
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7F5498@SHSMSX101.ccr.corp.intel.com>
References: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7E0E71@SHSMSX101.ccr.corp.intel.com>
 <1505816653-28715-1-git-send-email-shijith.thotton@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>, "Patil, Harish" <Harish.Patil@cavium.com>, "Zhang,
 Helin" <helin.zhang@intel.com>, Gregory Etelson <gregory@weka.io>, "Tan,
 Jianfeng" <jianfeng.tan@intel.com>, "Hu, Xuekun" <xuekun.hu@intel.com>, "Li,
 Xiaoyun" <xiaoyun.li@intel.com>, "Thotton, Shijith"
 <Shijith.Thotton@cavium.com>, "stable@dpdk.org" <stable@dpdk.org>
To: Shijith Thotton <shijith.thotton@caviumnetworks.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1505816653-28715-1-git-send-email-shijith.thotton@caviumnetworks.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com]
> Sent: Tuesday, September 19, 2017 6:24 PM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>; Yang, Qiming <qiming.yang@intel.com>; Patil, Haris=
h
> <Harish.Patil@cavium.com>; Zhang, Helin <helin.zhang@intel.com>; Gregory
> Etelson <gregory@weka.io>; Tan, Jianfeng <jianfeng.tan@intel.com>; Hu,
> Xuekun <xuekun.hu@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Thotton=
,
> Shijith <Shijith.Thotton@cavium.com>; stable@dpdk.org
> Subject: [PATCH] igb_uio: remove PCI reset during uio device open
>=20
> Issuing reset during uio device open caused PMD init failure for some NIC=
 VFs
> (i40, ixgbe, qede) in host. So this initial reset is removed.
> Bus master enable is kept as part of open since we disable it in uio devi=
ce release.
>=20
> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of devic=
e file")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
> ---
>  lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> index 07a19a3..a6c2996 100644
> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> @@ -179,9 +179,7 @@ struct rte_uio_pci_dev {
>  	struct rte_uio_pci_dev *udev =3D info->priv;
>  	struct pci_dev *dev =3D udev->pdev;
>=20
> -	pci_reset_function(dev);
> -
> -	/* set bus master, which was cleared by the reset function */
> +	/* enable bus mastering on the device */
>  	pci_set_master(dev);
>=20
>  	return 0;
> --
> 1.8.3.1

Tested-by: Qiming Yang <qiming.yang@intel.com>

Hi, applied and tested this patch with 17.08 DPDK VF and
2.1.26 kernel PF and it fixes the problem on 10G/25G/40G.