From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Qiming" Subject: Re: [DPDK] lib/librte_ether: add comments RSS flags Date: Wed, 10 Jan 2018 02:15:16 +0000 Message-ID: References: <20180104181506.153697-1-qiming.yang@intel.com> <3cf12026-efe5-6090-0bb1-4f9cba721ed9@solarflare.com> <1569196.tzFYU9QD0F@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Shahaf Shuler , Andrew Rybchenko , "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5FDD11B01D for ; Wed, 10 Jan 2018 03:15:19 +0100 (CET) In-Reply-To: <1569196.tzFYU9QD0F@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, January 8, 2018 4:33 AM > To: Yang, Qiming > Cc: Shahaf Shuler ; Andrew Rybchenko > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags >=20 > 07/01/2018 07:32, Shahaf Shuler: > > Saturday, January 6, 2018 12:22 PM, Andrew Rybchenko: > > > > [..] > > > > > > #define ETH_RSS_PORT (1ULL << RTE_ETH_FLOW_PORT) > > > > +/** Enable RSS offload on VXLAN packets */ > > > > #define ETH_RSS_VXLAN (1ULL << RTE_ETH_FLOW_VXLAN) > > > > +/** Enable RSS offload on GENEVE packets */ > > > > #define ETH_RSS_GENEVE (1ULL << RTE_ETH_FLOW_GENEVE) > > > > +/** Enable RSS offload on NVGRE packets */ > > > > #define ETH_RSS_NVGRE (1ULL << RTE_ETH_FLOW_NVGRE) > > > > > > > > #define ETH_RSS_IP ( \ > > > > > > These comments just decode the define name and not that useful. What > > > would be really useful here is specification of which fields of the > > > packet headers are used to calculate hash especially in the case of t= unnels. > > > > +1. > > > > Also maybe some more clarifications, for example: > > 1. What is the expected behavior when, for example, setting the > ETH_RSS_IPV6_EX and regular IPv6 packet arrives? is RSS apply on it? > > 2. What is the expected behavior from the PMD when not supporting one o= f > the RSS types? > > For example most of the DPDK examples uses ETH_RSS_IP [1], however > very few devices actually supports each and every RSS type. > > Assuming such configuration returns with no error, what should app= lication > expect when unsupported packet type arrives. > > > > #define ETH_RSS_IP ( \ > > ETH_RSS_IPV4 | \ > > ETH_RSS_FRAG_IPV4 | \ > > ETH_RSS_NONFRAG_IPV4_OTHER | \ > > ETH_RSS_IPV6 | \ > > ETH_RSS_FRAG_IPV6 | \ > > ETH_RSS_NONFRAG_IPV6_OTHER | \ > > ETH_RSS_IPV6_EX) >=20 > +1 > We really need a detailed documentation of the. >=20 I agree with your comments, but the same RSS configuration may have differe= nt behavior(RSS offload and input set) in different driver. Adding driver s= pecific information in rte_ethdev.h is not suitable. So I think the best scheme is to update driver's document to detail the exa= ct behavior and add reference doc here. > It must be at least as detailed as lib/librte_mbuf/rte_mbuf_ptype.h. > Thanks