From mboxrd@z Thu Jan 1 00:00:00 1970 From: Louis Luo Subject: Re: [PATCH 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug Date: Mon, 17 Sep 2018 19:06:30 +0000 Message-ID: References: <20180816135032.28283-1-bluca@debian.org> <20180816135032.28283-3-bluca@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "maxime.coquelin@redhat.com" , "tiwei.bie@intel.com" , Yong Wang , "3chas3@gmail.com" <3chas3@gmail.com>, "bruce.richardson@intel.com" , "jianfeng.tan@intel.com" , "anatoly.burakov@intel.com" , "stable@dpdk.org" , Brian Russell To: Luca Boccassi , "dev@dpdk.org" Return-path: In-Reply-To: <20180816135032.28283-3-bluca@debian.org> Content-Language: en-US Content-ID: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" SGkgTHVjYSwNCg0KV2hlbiBldGhfdm14bmV0M19kZXZfdW5pbml0KCkgaXMgY2FsbGVkLCBpcyBp dCBndWFyYW50ZWVkIHRoYXQgdm14bmV0M19kZXZfY2xvc2UvIHZteG5ldDNfZGV2X3N0b3AgbXVz dCBoYXZlIGJlZW4gY2FsbGVkPyBJJ20gbm90IGZhbWlsaWFyIHdpdGggdGhlIGhvdC1wbHVnIHBy b2NlZHVyZSwgc28ganVzdCB3b25kZXIgaWYgdGhlcmUgaXMgYW55IGNoYW5jZSB0aGF0IGV0aF92 bXhuZXQzX2Rldl91bmluaXQoKSBpcyBjYWxsZWQgd2l0aG91dCBjYWxsaW5nIHZteG5ldDNfZGV2 X2Nsb3NlLyB2bXhuZXQzX2Rldl9zdG9wLg0KDQpUaGFua3MsDQpMb3Vpcw0KDQrvu79PbiA4LzE2 LzE4LCA2OjUxIEFNLCAiZGV2IG9uIGJlaGFsZiBvZiBMdWNhIEJvY2Nhc3NpIiA8ZGV2LWJvdW5j ZXNAZHBkay5vcmcgb24gYmVoYWxmIG9mIGJsdWNhQGRlYmlhbi5vcmc+IHdyb3RlOg0KDQogICAg VGhlIHZteG5ldDMgZHJpdmVyIGNhbid0IGNhbGwgYmFjayBpbnRvIGRldl9jbG9zZSgpLCBhbmQg cG9zc2libHkNCiAgICBkZXZfc3RvcCgpLCBpbiBkZXZfdW5pbml0KCkuICBXaGVuIGRldl91bmlu aXQoKSBpcyBjYWxsZWQsIGFueXRoaW5nDQogICAgdGhhdCB0aG9zZSByb3V0aW5lcyB3b3VsZCB3 YW50IHRvIGNsZWFuIHVwIGhhcyBhbHJlYWR5IGJlZW4gcmVsZWFzZWQuDQogICAgRnVydGhlciwg Zm9yIGNvbXBsZXRlIGNsZWFudXAsIGl0IGlzIG5lY2Vzc2FyeSB0byByZWxlYXNlIGFueSBvZiB0 aGUNCiAgICBxdWV1ZSByZXNvdXJjZXMgZHVyaW5nIGRldl9jbG9zZSgpLg0KICAgIFRoaXMgYWxs b3dzIGEgdm14bmV0MyBkZXZpY2UgdG8gYmUgaG90LXVucGx1Z2dlZCB3aXRob3V0IGxlYWtpbmcN CiAgICBxdWV1ZXMuDQogICAgDQogICAgRml4ZXM6IGRmYWZmMzdmYzQ2ZCAoInZteG5ldDM6IGlt cG9ydCBuZXcgdm14bmV0MyBwb2xsIG1vZGUgZHJpdmVyIGltcGxlbWVudGF0aW9uIikNCiAgICBD Yzogc3RhYmxlQGRwZGsub3JnDQogICAgDQogICAgU2lnbmVkLW9mZi1ieTogQnJpYW4gUnVzc2Vs bCA8YnJ1c3NlbGxAYnJvY2FkZS5jb20+DQogICAgU2lnbmVkLW9mZi1ieTogTHVjYSBCb2NjYXNz aSA8Ymx1Y2FAZGViaWFuLm9yZz4NCiAgICAtLS0NCiAgICAgZHJpdmVycy9uZXQvdm14bmV0My92 bXhuZXQzX2V0aGRldi5jIHwgMzYgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLQ0KICAgICAx IGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pDQogICAgDQog ICAgZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3ZteG5ldDMvdm14bmV0M19ldGhkZXYuYyBiL2Ry aXZlcnMvbmV0L3ZteG5ldDMvdm14bmV0M19ldGhkZXYuYw0KICAgIGluZGV4IDI2MTNjZDEzNTgu LmI1ZDRiZTVlMjQgMTAwNjQ0DQogICAgLS0tIGEvZHJpdmVycy9uZXQvdm14bmV0My92bXhuZXQz X2V0aGRldi5jDQogICAgKysrIGIvZHJpdmVycy9uZXQvdm14bmV0My92bXhuZXQzX2V0aGRldi5j DQogICAgQEAgLTM0OCwxNiArMzQ4LDExIEBAIGV0aF92bXhuZXQzX2Rldl9pbml0KHN0cnVjdCBy dGVfZXRoX2RldiAqZXRoX2RldikNCiAgICAgc3RhdGljIGludA0KICAgICBldGhfdm14bmV0M19k ZXZfdW5pbml0KHN0cnVjdCBydGVfZXRoX2RldiAqZXRoX2RldikNCiAgICAgew0KICAgIC0Jc3Ry dWN0IHZteG5ldDNfaHcgKmh3ID0gZXRoX2Rldi0+ZGF0YS0+ZGV2X3ByaXZhdGU7DQogICAgLQ0K ICAgICAJUE1EX0lOSVRfRlVOQ19UUkFDRSgpOw0KICAgICANCiAgICAgCWlmIChydGVfZWFsX3By b2Nlc3NfdHlwZSgpICE9IFJURV9QUk9DX1BSSU1BUlkpDQogICAgIAkJcmV0dXJuIDA7DQogICAg IA0KICAgIC0JaWYgKGh3LT5hZGFwdGVyX3N0b3BwZWQgPT0gMCkNCiAgICAtCQl2bXhuZXQzX2Rl dl9jbG9zZShldGhfZGV2KTsNCiAgICAtDQogICAgIAlldGhfZGV2LT5kZXZfb3BzID0gTlVMTDsN CiAgICAgCWV0aF9kZXYtPnJ4X3BrdF9idXJzdCA9IE5VTEw7DQogICAgIAlldGhfZGV2LT50eF9w a3RfYnVyc3QgPSBOVUxMOw0KICAgIEBAIC04MDMsNyArNzk4LDcgQEAgdm14bmV0M19kZXZfc3Rv cChzdHJ1Y3QgcnRlX2V0aF9kZXYgKmRldikNCiAgICAgCVBNRF9JTklUX0ZVTkNfVFJBQ0UoKTsN CiAgICAgDQogICAgIAlpZiAoaHctPmFkYXB0ZXJfc3RvcHBlZCA9PSAxKSB7DQogICAgLQkJUE1E X0lOSVRfTE9HKERFQlVHLCAiRGV2aWNlIGFscmVhZHkgY2xvc2VkLiIpOw0KICAgICsJCVBNRF9J TklUX0xPRyhERUJVRywgIkRldmljZSBhbHJlYWR5IHN0b3BwZWQuIik7DQogICAgIAkJcmV0dXJu Ow0KICAgICAJfQ0KICAgICANCiAgICBAQCAtODI3LDcgKzgyMiw2IEBAIHZteG5ldDNfZGV2X3N0 b3Aoc3RydWN0IHJ0ZV9ldGhfZGV2ICpkZXYpDQogICAgIAkvKiByZXNldCB0aGUgZGV2aWNlICov DQogICAgIAlWTVhORVQzX1dSSVRFX0JBUjFfUkVHKGh3LCBWTVhORVQzX1JFR19DTUQsIFZNWE5F VDNfQ01EX1JFU0VUX0RFVik7DQogICAgIAlQTURfSU5JVF9MT0coREVCVUcsICJEZXZpY2UgcmVz ZXQuIik7DQogICAgLQlody0+YWRhcHRlcl9zdG9wcGVkID0gMDsNCiAgICAgDQogICAgIAl2bXhu ZXQzX2Rldl9jbGVhcl9xdWV1ZXMoZGV2KTsNCiAgICAgDQogICAgQEAgLTgzNyw2ICs4MzEsMzAg QEAgdm14bmV0M19kZXZfc3RvcChzdHJ1Y3QgcnRlX2V0aF9kZXYgKmRldikNCiAgICAgCWxpbmsu bGlua19zcGVlZCA9IEVUSF9TUEVFRF9OVU1fMTBHOw0KICAgICAJbGluay5saW5rX2F1dG9uZWcg PSBFVEhfTElOS19GSVhFRDsNCiAgICAgCXJ0ZV9ldGhfbGlua3N0YXR1c19zZXQoZGV2LCAmbGlu ayk7DQogICAgKw0KICAgICsJaHctPmFkYXB0ZXJfc3RvcHBlZCA9IDE7DQogICAgK30NCiAgICAr DQogICAgK3N0YXRpYyB2b2lkDQogICAgK3ZteG5ldDNfZnJlZV9xdWV1ZXMoc3RydWN0IHJ0ZV9l dGhfZGV2ICpkZXYpDQogICAgK3sNCiAgICArCWludCBpOw0KICAgICsNCiAgICArCVBNRF9JTklU X0ZVTkNfVFJBQ0UoKTsNCiAgICArDQogICAgKwlmb3IgKGkgPSAwOyBpIDwgZGV2LT5kYXRhLT5u Yl9yeF9xdWV1ZXM7IGkrKykgew0KICAgICsJCXZvaWQgKnJ4cSA9IGRldi0+ZGF0YS0+cnhfcXVl dWVzW2ldOw0KICAgICsNCiAgICArCQl2bXhuZXQzX2Rldl9yeF9xdWV1ZV9yZWxlYXNlKHJ4cSk7 DQogICAgKwl9DQogICAgKwlkZXYtPmRhdGEtPm5iX3J4X3F1ZXVlcyA9IDA7DQogICAgKw0KICAg ICsJZm9yIChpID0gMDsgaSA8IGRldi0+ZGF0YS0+bmJfdHhfcXVldWVzOyBpKyspIHsNCiAgICAr CQl2b2lkICp0eHEgPSBkZXYtPmRhdGEtPnR4X3F1ZXVlc1tpXTsNCiAgICArDQogICAgKwkJdm14 bmV0M19kZXZfdHhfcXVldWVfcmVsZWFzZSh0eHEpOw0KICAgICsJfQ0KICAgICsJZGV2LT5kYXRh LT5uYl90eF9xdWV1ZXMgPSAwOw0KICAgICB9DQogICAgIA0KICAgICAvKg0KICAgIEBAIC04NDUs MTIgKzg2MywxMCBAQCB2bXhuZXQzX2Rldl9zdG9wKHN0cnVjdCBydGVfZXRoX2RldiAqZGV2KQ0K ICAgICBzdGF0aWMgdm9pZA0KICAgICB2bXhuZXQzX2Rldl9jbG9zZShzdHJ1Y3QgcnRlX2V0aF9k ZXYgKmRldikNCiAgICAgew0KICAgIC0Jc3RydWN0IHZteG5ldDNfaHcgKmh3ID0gZGV2LT5kYXRh LT5kZXZfcHJpdmF0ZTsNCiAgICAtDQogICAgIAlQTURfSU5JVF9GVU5DX1RSQUNFKCk7DQogICAg IA0KICAgICAJdm14bmV0M19kZXZfc3RvcChkZXYpOw0KICAgIC0JaHctPmFkYXB0ZXJfc3RvcHBl ZCA9IDE7DQogICAgKwl2bXhuZXQzX2ZyZWVfcXVldWVzKGRldik7DQogICAgIH0NCiAgICAgDQog ICAgIHN0YXRpYyB2b2lkDQogICAgLS0gDQogICAgMi4xOC4wDQogICAgDQogICAgDQoNCg==