From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jonas Pfefferle1" Subject: Re: [PATCH v3 4/6] eal/memory: rename memory API to iovatypes Date: Fri, 3 Nov 2017 16:22:34 +0100 Message-ID: References: <20170905103119.20511-1-santosh.shukla@caviumnetworks.com> <5335497.nnbAZL8Naz@xps> <2572bad0-8023-3146-dfd1-1e0ef874fe70@caviumnetworks.com> <16080450.FyQkJaYVGX@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Cc: santosh , dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, anatoly.burakov@intel.com To: Thomas Monjalon Return-path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 2FD941B68C for ; Fri, 3 Nov 2017 16:22:44 +0100 (CET) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vA3FL1iB003411 for ; Fri, 3 Nov 2017 11:22:44 -0400 Received: from smtp.notes.na.collabserv.com (smtp.notes.na.collabserv.com [192.155.248.91]) by mx0a-001b2d01.pphosted.com with ESMTP id 2e0q2hqgd2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 03 Nov 2017 11:22:44 -0400 Received: from localhost by smtp.notes.na.collabserv.com with smtp.notes.na.collabserv.com ESMTP for from ; Fri, 3 Nov 2017 15:22:43 -0000 In-Reply-To: <16080450.FyQkJaYVGX@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" "dev" wrote on 11/03/2017 02:58:43 PM: > From: Thomas Monjalon > To: santosh > Cc: dev@dpdk.org, olivier.matz@6wind.com, > jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, > anatoly.burakov@intel.com > Date: 11/03/2017 02:59 PM > Subject: Re: [dpdk-dev] [PATCH v3 4/6] eal/memory: rename memory API > to iova types > Sent by: "dev" > > 03/11/2017 12:35, santosh: > > On Friday 03 November 2017 04:41 PM, Thomas Monjalon wrote: > > > 20/10/2017 14:31, Santosh Shukla: > > >> Renamed memory translational api to =5Fiova types. > > >> The following api renamed from: > > >> > > >> rte=5Fmempool=5Fpopulate=5Fphys() > > >> rte=5Fmempool=5Fpopulate=5Fphys=5Ftab() > > > These functions still have "physical addresses" in their description. > > > It is not consistent. > > > > > > Please provide ABI compatibility for mempool functions. > > > > > >> rte=5Feal=5Fusing=5Fphys=5Faddrs() > > > Why renaming rte=5Feal=5Fusing=5Fphys=5Faddrs? > > > I think we need to review how it is used. > > > Maybe it requires a rework. > > > > > >> rte=5Fmem=5Fvirt2phy() > > >> rte=5Fdump=5Fphysmem=5Flayout() > > >> rte=5Feal=5Fget=5Fphysmem=5Flayout() > > >> rte=5Feal=5Fget=5Fphysmem=5Fsize() > > > Those 3 functions deal with physical memory layout. > > > I don't see a need to rename them. > > > > In iova=3Dva mode, those api will have va address. > > Yes addresses can be virtual. > But it is still physically segmented. > > > > But the dump function needs a change to avoid printing > > > "phys" even in VA case. > > > > > >> rte=5Fmalloc=5Fvirt2phy() > > >> rte=5Fmem=5Fphy2mch() > > > This last function was removed with Xen. > > > It is wrong to rename it in the release notes. > > > It should just be removed from the map file (I will send a patch). > > > > > >> To the following iova types api: > > >> > > >> rte=5Fmempool=5Fpopulate=5Fiova() > > >> rte=5Fmempool=5Fpopulate=5Fiova=5Ftab() > > >> rte=5Feal=5Fusing=5Fiova=5Faddrs() > > >> rte=5Fmem=5Fvirt2iova() > > > [...] > > >> rte=5Fmalloc=5Fvirt2iova() > > > I am not convinced by the names virt2iova. > > > I sounds like "virt to virt". > > > What about "virt2io" or "virt2io=5Faddr"? > > > > no, iova can be =5Fpa or =5Fva, its an io=5Faddr indeed but > > I prefer virt2iova, same mentioned in deprecation notice (no > strong opinion), > > > > More suggestion on naming pl.? > > I like virt2io=5Faddr but virt2iova is not so bad. > I agree with Santosh that we need more opinions. virt2iova +1 Another suggestion va2iova to be consistent with the names > > > > As the ABI is broken in EAL 17.11, we do not care about compatibility. > > > But we must keep an alias to the old function name in order to allow > > > a smooth API transition for applications. > > > I suggest to add static inline functions with the old names and set > > > the deprecated attribute. > > > > ok, Will address in 18.02. > > I would prefer these changes made in 17.11 as announced. > As you are not willing to work on it, I am trying to send some > updated patches. >