DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Maxime Leroy <maxime@leroys.fr>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@oss.nxp.com>,
	Gagandeep Singh <g.singh@nxp.com>,
	 dev@dpdk.org, david.marchand@redhat.com,
	Hemant Agrawal <hemant.agrawal@oss.nxp.com>
Subject: Re: [PATCH v1 1/2] net/dpaa2: revert inner RSS level support
Date: Tue, 21 Jul 2026 23:25:10 +0200	[thread overview]
Message-ID: <SIzst5xFTHeltCemdlXt4A@monjalon.net> (raw)
In-Reply-To: <b4bd7d94-20b9-4e7c-b51c-7d428bc60b0a@oss.nxp.com>

21/07/2026 14:55, Hemant Agrawal:
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> On 21-07-2026 15:26, Thomas Monjalon wrote:
> > I'm waiting for an urgent reply from the maintainers here.
> >
> >
> > 20/07/2026 15:34, Maxime Leroy:
> >> This reverts commit 618a06c53d479ae576ff01c7d274b10c60b3d3d5.
> >>
> >> RTE_ETH_RSS_LEVEL_INNERMOST was mapped to the innermost IP instance by
> >> programming the IP key extracts with hdr_index = HDR_INDEX_LAST. The
> >> hardware only resolves that index when several IP headers are stacked.
> >> A non-tunnelled frame carries a single IP header, so the extract
> >> resolves to nothing, the RSS hash is constant and every such frame is
> >> steered to a single Rx queue.
> >>
> >> The ethdev API defines INNERMOST by encapsulation level, not by the
> >> presence of a tunnel: a plain frame's innermost header is its only IP
> >> header and must be hashed. The dpaa2 hardware cannot honour that and
> >> keep true inner-only semantics for tunnelled traffic at the same time,
> >> so the level cannot be implemented correctly as merged.
> >>
> >> Revert it. Hashing the outer plus the inner IP under the PMD default
> >> level, which spreads both plain and tunnelled traffic, is added in a
> >> follow-up.
> >>
> >> Signed-off-by: Maxime Leroy <maxime@leroys.fr>

Applied, thanks.



  reply	other threads:[~2026-07-21 21:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 12:38 [RFC PATCH] net/dpaa2: fix RSS at inner level for non-tunnelled traffic Maxime Leroy
2026-07-15 17:00 ` Maxime Leroy
2026-07-16  7:47   ` Hemant Agrawal
2026-07-16  8:00     ` Maxime Leroy
2026-07-20 13:34 ` [PATCH v1 0/2] net/dpaa2: fix RSS for plain and tunnelled traffic Maxime Leroy
2026-07-23  9:35   ` [PATCH v2] net/dpaa2: hash inner IP for " Maxime Leroy
2026-07-20 13:34 ` [PATCH v1 1/2] net/dpaa2: revert inner RSS level support Maxime Leroy
2026-07-21  9:56   ` Thomas Monjalon
2026-07-21 12:55     ` Hemant Agrawal
2026-07-21 21:25       ` Thomas Monjalon [this message]
2026-07-20 13:34 ` [PATCH v1 2/2] net/dpaa2: hash inner IP for tunnelled traffic Maxime Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SIzst5xFTHeltCemdlXt4A@monjalon.net \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=g.singh@nxp.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hemant.agrawal@oss.nxp.com \
    --cc=maxime@leroys.fr \
    --cc=sachin.saxena@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox