DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Huisong Li <lihuisong@huawei.com>
Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru,
	zhanjie9@hisilicon.com,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"David Marchand" <david.marchand@redhat.com>
Subject: Re: [PATCH v1 0/5] prefix lcore role enum values
Date: Thu, 18 Jun 2026 18:19:37 +0200	[thread overview]
Message-ID: <SdThFrO9S62xAryFCraiCQ@monjalon.net> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35F65917@smartserver.smartshare.dk>

17/06/2026 13:48, Morten Brørup:
> > From: Huisong Li [mailto:lihuisong@huawei.com]
> > Sent: Wednesday, 17 June 2026 12.28
> > 
> > Add the RTE_LCORE_ prefix to the lcore role enum values in
> > rte_lcore_role_t
> > to follow DPDK naming conventions.
> > 
> > - ROLE_RTE      -> RTE_LCORE_ROLE_RTE
> > - ROLE_OFF      -> RTE_LCORE_ROLE_OFF
> > - ROLE_SERVICE  -> RTE_LCORE_ROLE_SERVICE
> > - ROLE_NON_EAL  -> RTE_LCORE_ROLE_NON_EAL
> > 
> > Old names are kept as macros aliasing to the new names to preserve
> > backward compatibility.
> > 
> 
> Series-Acked-by: Morten Brørup <mb@smartsharesystems.com>

Squashed and applied, thanks.

I have a doubt about RTE_LCORE_ROLE_RTE: could we find a better name?

Also we should probably add some comments to explain each role.




  reply	other threads:[~2026-06-18 16:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 10:28 [PATCH v1 0/5] prefix lcore role enum values Huisong Li
2026-06-17 10:28 ` [PATCH v1 1/5] eal: " Huisong Li
2026-06-17 10:28 ` [PATCH v1 2/5] eal: use new lcore role enum names Huisong Li
2026-06-17 10:28 ` [PATCH v1 3/5] graph: " Huisong Li
2026-06-17 10:28 ` [PATCH v1 4/5] net/softnic: " Huisong Li
2026-06-17 10:28 ` [PATCH v1 5/5] test: " Huisong Li
2026-06-17 11:48 ` [PATCH v1 0/5] prefix lcore role enum values Morten Brørup
2026-06-18 16:19   ` Thomas Monjalon [this message]
2026-06-18 18:52     ` Morten Brørup
2026-06-19  2:03   ` Stephen Hemminger
2026-06-19  7:28     ` Thomas Monjalon
2026-06-19  7:54       ` Morten Brørup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SdThFrO9S62xAryFCraiCQ@monjalon.net \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=lihuisong@huawei.com \
    --cc=mb@smartsharesystems.com \
    --cc=zhanjie9@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox